Bug 42325 - Implement the "clear" method for the LogicControllers
Implement the "clear" method for the LogicControllers
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: HTTP
2.2
All All
: P2 enhancement (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-05-03 03:19 UTC by Alf Hogemark
Modified: 2007-05-04 08:09 UTC (History)
0 users



Attachments
Suggested patch (25.10 KB, patch)
2007-05-03 03:37 UTC, Alf Hogemark
Details | Diff
Implement clear for IncludeController and ModuleController (1.91 KB, patch)
2007-05-04 03:32 UTC, Alf Hogemark
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alf Hogemark 2007-05-03 03:19:23 UTC
When the suggested patch for bug 30120 has been applied, it becomes apparent
that the logic controllers are missing implementations of the "clear" method.
Because when a new logic controller is added, for example "IF controller", and
there already exists an "If controller" in the test plan with an expression set,
the newly added "If controller" has the same expression initially.
The newly added "If controller" should have a blank expression initially.
Comment 1 Alf Hogemark 2007-05-03 03:37:46 UTC
Created attachment 20115 [details]
Suggested patch

This patch adds implementation of the "clear" method for most of the logic
controllers. It does not implement "clear" for the IncludeController and
ModuleController.

The patch also adds // $NON-NLS-1$ comments, let me know if that is only
confusing, and I can make a patch with only the clear method.

The patch also adds a resource string for the label for the dropdown box of
ModuleController.
Comment 2 Sebb 2007-05-04 03:23:59 UTC
Thanks - added to SVN in r535147 and r535151.

As to the NLS-only and resource fixes, I added them as separate commits.

It's OK to add NLS markers to files that already are being updated, but in 
future please use a separate patch file for changes to other files that are 
unrelated to the current bug report. This makes it easier to follow the 
history later.

Comment 3 Alf Hogemark 2007-05-04 03:32:32 UTC
Created attachment 20130 [details]
Implement clear for IncludeController and ModuleController

This patch adds "clear" method to the two remaining logic controllers,
IncludeController and ModuleController
Comment 4 Sebb 2007-05-04 08:09:49 UTC
Thanks - patch 20130 added to SVN in r535284