Bug 41608 - The log level is different at same messages.
The log level is different at same messages.
Status: RESOLVED FIXED
Product: Tomcat 5
Classification: Unclassified
Component: Catalina
5.5.20
All All
: P5 trivial (vote)
: ---
Assigned To: Tomcat Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-02-13 21:45 UTC by Suzuki Yuichiro
Modified: 2008-12-30 02:16 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Suzuki Yuichiro 2007-02-13 21:45:29 UTC
I suggest a little message improvement.

The log level is different at same messages.
The message "Servlet.service() for servlet {0} threw exception" is 
output in eight places, but the message level is not same.

--org.apache.catalina.core.ApplicationDispatcher#invoke
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), e);
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), e);
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), rootCause);
...
wrapper.getLogger().error(sm.getString("applicationDispatcher.serviceException",
    wrapper.getName()), e);


--org.apache.catalina.core.StandardWrapperValve#invoke
container.getLogger().warn(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), e);
...
container.getLogger().warn(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), e);
...
container.getLogger().error(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), rootCause);
...
container.getLogger().error(sm.getString("standardWrapper.serviceException",
    wrapper.getName()), e);

Are there any reasons for using getLogger().warn()?
I think it would be better that all of them use getLogger().error(...).
Comment 1 Mark Thomas 2007-02-15 19:09:59 UTC
Fixe din svn for 5.5.x and 6.0.x. Thanks for the report.