Bug 39437 - NTEventLogAppender uses code from JNI Prog Manual
Summary: NTEventLogAppender uses code from JNI Prog Manual
Status: RESOLVED FIXED
Alias: None
Product: Log4j - Now in Jira
Classification: Unclassified
Component: Appender (show other bugs)
Version: 1.3alpha
Hardware: Other other
: P2 normal
Target Milestone: ---
Assignee: log4j-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-27 22:59 UTC by Curt Arnold
Modified: 2006-04-27 16:00 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curt Arnold 2006-04-27 22:59:31 UTC 
Discussed on log4j-dev on 19 Mar 2006
(http://marc.theaimsgroup.com/?l=log4j-dev&m=114274873223429&w=2).

Janet Campbell of Eclipse Foundation Inc. expressed concerns that
src/java/org/apache/log4j/nt/nteventlog.cpp contained about 60 lines of code
that  was copied  from "The Java Native Interface: Programmer's Guide and
Specification"  (http://java.sun.com/docs/books/jni).  The code was used to
perform an unnecessary conversion of Java strings to the local code page. 
nteventlog.cpp in the trunk has been modified to avoid the unnecessary
conversion and no longer contains the code of concern.
Comment 1 Curt Arnold 2006-04-27 23:00:48 UTC 
Committed rev 397672.