Bug 37506 - [Patch] Refactor FontReaders (PFM and TTF)
Summary: [Patch] Refactor FontReaders (PFM and TTF)
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: general (show other bugs)
Version: all
Hardware: Other other
: P2 enhancement
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-15 11:13 UTC by Kev Jackson
Modified: 2012-04-01 07:01 UTC (History)
0 users


Attachments
refactors to extract common features (11.76 KB, patch)
2005-11-15 11:14 UTC, Kev Jackson 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kev Jackson 2005-11-15 11:13:51 UTC 
I was looking at the code and noticed how similar these two 'apps' actually are.
 So I extracted the most common functionality into a base class and inherited
from it, prinicple of DRY I suppose.  I'm sure more could be done to extract
even more commonality, but this was really low-hanging.  Anyway included patch
for consideration.
Comment 1 Kev Jackson 2005-11-15 11:14:32 UTC 
Created attachment 16974 [details]
refactors to extract common features
Comment 2 Jeremias Maerki 2006-01-25 22:18:42 UTC 
Patch (finally) applied. Thanks for it! Something small but still worthwhile.
http://svn.apache.org/viewcvs?rev=372317&view=rev
Comment 3 Glenn Adams 2012-04-01 07:01:26 UTC 
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed