Bug 37156 - Formatted view of Request in Results Tree
Formatted view of Request in Results Tree
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: HTTP
unspecified
Other other
: P2 enhancement with 2 votes (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2005-10-19 09:51 UTC by Sebastian Nohn
Modified: 2010-10-11 18:56 UTC (History)
0 users



Attachments
Draft patch for comments (10.71 KB, patch)
2010-08-21 06:03 UTC, Milamber
Details | Diff
new files for draft patch (10.12 KB, application/x-sdlc)
2010-08-21 06:03 UTC, Milamber
Details
Some screenshots to view the patch in action (219.25 KB, application/x-sdlc)
2010-08-21 06:04 UTC, Milamber
Details
New proposal patch before commit (9.24 KB, application/zip)
2010-10-11 18:46 UTC, Milamber
Details
New proposal patch before commit (14.39 KB, patch)
2010-10-11 18:47 UTC, Milamber
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Nohn 2005-10-19 09:51:03 UTC
If you send dozens of encoded data, it is hard to find out which data has been sent.

It would be nice ot have a formatted (tabular, decoded) view of a request in the
results tree.
Comment 1 Milamber 2010-08-16 15:28:34 UTC
Hello,

I work on a proposal's patch to this enhancement (linked too with Bug 15999)

I propose to add a new interface "RequestView" for the request tab/pane in listener View Results Tree, driven by a "RequestPanel" class which load all class which implements RequestView. 

There will have a request pane with tabs on bottom ("Raw", "HTTP" or other if JMS/JDBC/LDAP/etc) when we look a HTTP Sampler Result.

In HTTP pane, there will have some tables: request URL decoded, Params decoded and request headers.

Normally, next week I will putting a patch on bugzilla with some screen-shots.
Comment 2 Milamber 2010-08-21 06:03:00 UTC
Created attachment 25920 [details]
Draft patch for comments
Comment 3 Milamber 2010-08-21 06:03:40 UTC
Created attachment 25921 [details]
new files for draft patch
Comment 4 Milamber 2010-08-21 06:04:18 UTC
Created attachment 25922 [details]
Some screenshots to view the patch in action
Comment 5 Milamber 2010-08-21 06:08:48 UTC
I send a draft (proposal) patch. 

*Any comments are welcome.*

I have this comments/questions:
* Find a way to display large parameter value (like SOAP) (perhaps a button at right "More" in 3rd column with a new Message box)
* Need to parse cookies values (multiple cookie)? (new table or more button?)
* The decoding of HTTP parameters is in ISO-8859-1, is good?
* Try to display only tab for current sample type ? (if current sampler is not HTTP, need to display HTTP bottom tab?)
* Some methods (querymap, parse param) in the RequestViewHTTP class can be promoted to JMeterUtils (or a new class HTTPUtils)

On Response data tab and their combo box (Text, HTML, regexp, etc;) : perhaps use bottom tabs on response data panel and remove combo box? (same the new request panel)
With tabs we need only one click to change response view (before 2 clicks actually : display list + choose)
Comment 6 Sebb 2010-08-31 15:13:10 UTC
Looks fine to me.

Since these are additional features which don't change the existing functions, I think the best would be to incorporate the changes, and then ask for feedback on the user list (not the dev list).
Comment 7 Milamber 2010-10-11 18:46:51 UTC
Created attachment 26158 [details]
New proposal patch before commit
Comment 8 Milamber 2010-10-11 18:47:26 UTC
Created attachment 26159 [details]
New proposal patch before commit
Comment 9 Milamber 2010-10-11 18:56:10 UTC
Enhancement added in SVN; Please re-open if necessary

URL: http://svn.apache.org/viewvc?rev=1021539&view=rev
Log:
Bug 37156 - Formatted view of Request in Results Tree

Added:
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestPanel.java   (with props)
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestView.java   (with props)
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/RequestViewRaw.java   (with props)
    jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/
    jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java   (with props)
Modified:
    jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jakarta/jmeter/trunk/src/core/org/apache/jmeter/util/JMeterUtils.java
    jakarta/jmeter/trunk/xdocs/changes.xml