Bug 35918 - [PATCH] Shapes are slightly shifted with respect to lines on larger graphics
Summary: [PATCH] Shapes are slightly shifted with respect to lines on larger graphics
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: pdf (show other bugs)
Version: trunk
Hardware: Other other
: P2 major
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-28 17:48 UTC by Martin Weindel
Modified: 2012-04-01 06:42 UTC (History)
0 users



Attachments
patch to write transformation matrix with higher precision (1.29 KB, patch)
2005-07-28 17:51 UTC, Martin Weindel
Details | Diff
sample FO, SVG and resulting PDF (116.66 KB, application/x-zip-compressed)
2005-07-30 21:31 UTC, Martin Weindel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Weindel 2005-07-28 17:48:08 UTC
Due to insufficient precision of the transformation matrix, shapes are not
correctly positioned on larger graphics. As lines are rendered differently this
results in ugly, unusable PDF output.
The resolution is simple to provide a better precision in the PDF output (see
attached patch).
Comment 1 Martin Weindel 2005-07-28 17:51:08 UTC
Created attachment 15816 [details]
patch to write transformation matrix with higher precision
Comment 2 Jeremias Maerki 2005-07-30 11:33:52 UTC
Thanks for the patch. Do you have an example that shows the effect of your 
change that you could attach to this issue?
Comment 3 Martin Weindel 2005-07-30 21:31:10 UTC
Created attachment 15829 [details]
sample FO, SVG and resulting PDF

This bug is more complex than I have thought firstly.
My patch helps only when using the Batik rasterizer (Batik 1.6 with patched
pdf-transcoder.jar (alias fop-transcoder-allinone.jar in fop trunk)).
commandline: java -jar batik-rasterizer.jar -m application/pdf bug35918.svg

But if you use the FOP directly, the bug still exists.
commandline: fop bug35918.fo bug35918.pdf
Comment 4 Jeremias Maerki 2005-08-26 23:04:07 UTC
I did a few things on PDFGraphics2D to improve the situation:
http://svn.apache.org/viewcvs?rev=240344&view=rev

I didn't actually apply your patch but followed your example while refactoring
the code. Thanks all the same!

Your test case looks good to me now.
Comment 5 Glenn Adams 2012-04-01 06:42:08 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed