Bug 33845 - Remove dependency to NewDriver class from JMeter class
Remove dependency to NewDriver class from JMeter class
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
unspecified
PC Linux
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2005-03-04 15:16 UTC by viggo
Modified: 2005-03-10 17:32 UTC (History)
0 users



Attachments
Dynamically set jmeter home using attribute (25.67 KB, patch)
2005-03-08 08:30 UTC, viggo
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description viggo 2005-03-04 15:16:30 UTC
In the current version of JMeter.java, jmeter home is set by calling
JMeterUtils.setJMeterHome(NewDriver.getJMeterDir()). This creates an unnecessary
dependency to the NewDriver class..
A better solution would be to give jmeter home as input parameter to the JMeter
class.

I can provide code to show how this could be implemented.
Comment 1 Sebb 2005-03-04 21:00:04 UTC
Why is the dependency a problem?
Comment 2 viggo 2005-03-07 10:43:57 UTC
(In reply to comment #1)
> Why is the dependency a problem?

The dependency is a problem because I want to run JMeter from Maven, and I don't
want to use NewDriver, I want to run the JMeter class directly. NewDriver is
just a "wrapper-class" setting up dependencies, I want Maven to set up these
dependencies for me.

Comment 3 Sebb 2005-03-07 14:22:49 UTC
OK, I think I see.

Can you attach a patch?

We'd need to be sure that existing code and usage was not impacted in any way
before changing anything.
Comment 4 viggo 2005-03-08 08:30:51 UTC
Created attachment 14428 [details]
Dynamically set jmeter home using attribute

Introducing a new attribute -d which makes it possible to apply jmeter home
directory as input paramter to JMeter.java. If -d is not set, it will use the
existing approach to set jmeter home.
Comment 5 Sebb 2005-03-11 02:32:45 UTC
Thanks - change added to 2.0 branch