Bug 31512 - [PATCH] Fop should use Batik's Image readers when possible
Summary: [PATCH] Fop should use Batik's Image readers when possible
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: images (show other bugs)
Version: 0.15
Hardware: Other other
: P3 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-10-02 18:02 UTC by Thomas Deweese
Modified: 2012-04-01 06:52 UTC (History)
0 users


Attachments
Patch file and new files for PNG and TIFF support (32.64 KB, application/octet-stream)
2004-10-02 18:04 UTC, Thomas Deweese 		Details
Updated Patch with Apache License on source files (33.20 KB, application/octet-stream)
2004-10-11 10:36 UTC, Thomas Deweese 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deweese 2004-10-02 18:02:39 UTC 
Fop should use Batik's image readers when possible rather than
relying on additional libraries.

The attached patch changes PNG and TIFF to use the Batik
codecs which are already shipped with FOP.

The patch also adds support for 'softMasks' (alpha channels)
for PNG and TIFF (at least for PDF output).

Enjoy!
Comment 1 Thomas Deweese 2004-10-02 18:04:04 UTC 
Created attachment 12921 [details]
Patch file and new files for PNG and TIFF support
Comment 2 Jeremias Maerki 2004-10-10 14:11:16 UTC 
Thomas,

thank you for the patch. Looks interesting. I don't want to play nitpicker, but
from what I've seen from discussion in the incubator it would be best, if you
would resubmit the two new Java files with the Apache license header, just so
everybody is clear that these files were meant to be submitted to the FOP
project for inclusion. Sorry for the trouble.

A long thread, just for reference:
http://nagoya.apache.org/eyebrowse/BrowseList?listName=general@incubator.apache.org&by=thread&from=883584
Comment 3 Thomas Deweese 2004-10-11 10:36:36 UTC 
Created attachment 13021 [details]
Updated Patch with Apache License on source files
Comment 4 Thomas Deweese 2004-10-11 10:38:10 UTC 
Ooops! Sorry about that.
You are 100% correct the code needs to be under the Apache License.
Comment 5 Jeremias Maerki 2004-10-11 21:09:05 UTC 
Applied. Thanks, Thomas. Some people will be very happy about this change.
Comment 6 Glenn Adams 2012-04-01 06:52:03 UTC 
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed