Bug 20868 - max external graphic height depends on region-body
Summary: max external graphic height depends on region-body
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: images (show other bugs)
Version: 0.20.5
Hardware: All All
: P3 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-18 13:13 UTC by Florian Kunkel
Modified: 2012-04-01 07:07 UTC (History)
0 users



Attachments
Proposed patch (756 bytes, patch)
2003-06-18 17:05 UTC, Larry Moore
Details | Diff
Some fo files to illustrate the problem. (zip) (4.72 KB, application/octet-stream)
2003-08-14 08:36 UTC, Henrik Olsson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Kunkel 2003-06-18 13:13:53 UTC
I try to produce a Spare Parts List PDF with Apache FOP 0.20.5rc3a. On even 
pages I just have a static explosion drawing and on odd pages a table with 
spare parts, that can spread over multiple pages. To do this I use repeatable-
page-master-alternatives. To get nice page breaks, I have a pseudo region-body 
with a height of 1mm on the even pages (the flow is the table, the explosion 
drawing is on a static-content-area).

Unfortunately I had to find out, that the external graphic on the static 
content area cannot be higher than the height of the region-body. Since I only 
have a pseudo region-body of 1mm height, the image is rendered far too small ;)

I do not think that this is desired behaviour. So I stepped into the source 
code (I start to love open source).

And in org.apache.fop.fo.flow.ExternalGraphic.layout(Area area) in line 209 I 
found out that the maximum height of the external graphic is indeed dependent 
on "area.getPage().getBody().getMaxHeight()". But this class is used for static 
content areas, too.

I changed this to "area.spaceLeft()".

For my special rendering this works fine. Of course, I do not have a clue, if 
this is a solution for any boundary condition.

I would really appreciate if you could have a look at it.

Thanks,

FloH
Comment 1 Larry Moore 2003-06-18 17:05:38 UTC
Created attachment 6874 [details]
Proposed patch
Comment 2 Larry Moore 2003-06-18 17:07:31 UTC
Oops, ignore attachment. Wrong bug.
Comment 3 Henrik Olsson 2003-08-14 08:36:58 UTC
Created attachment 7813 [details]
Some fo files to illustrate the problem. (zip)
Comment 4 Pascal Sancho 2007-10-23 08:26:53 UTC
Bug fixed in latest Trunk (rev 584703), and probably in FOP 0.94
Comment 5 Glenn Adams 2012-04-01 07:07:19 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed