Bug 14659 - [PATCH] spurious (nuisance) errors on print/awt renderers
Summary: [PATCH] spurious (nuisance) errors on print/awt renderers
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: awt renderer (show other bugs)
Version: 0.20.4
Hardware: PC All
: P3 minor
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-18 23:19 UTC by Ralph LaChance
Modified: 2012-04-01 07:09 UTC (History)
0 users



Attachments
patch added as attachement (now that lf's are fixed in PrintStarter.java) (1.75 KB, patch)
2002-11-19 17:23 UTC, Ralph LaChance
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph LaChance 2002-11-18 23:19:10 UTC
Both the awt renderer and the print renderer output some
spurious error messages to the 
logger.
Comment 1 Ralph LaChance 2002-11-18 23:25:46 UTC
I've worked out a corrections for both of these minor annoyances.
I'm not sure these are the 
~right~ solutions, but they work.

btw:  There seems to be a problem (line endings?) 
with
fop.app.PrintStarter.java - If I make a single character change
in the file, diff 
reports that the whole thing changed   ;-(

The actual diff is appended below for AWTStarter, 

a ~description~ of the change to PrintStarter follow below that....

Index: xml-
fop/src/org/apache/fop/apps/AWTStarter.java
===================================================================
RCS 
file: /home/cvspublic/xml-fop/src/org/apache/fop/apps/AWTStarter.java,v
retrieving 
revision 1.9.2.4
diff -u -r1.9.2.4 AWTStarter.java
--- xml-
fop/src/org/apache/fop/apps/AWTStarter.java	4 Jul 2002 12:00:25 -0000	1.9.2.4
+++ xml-
fop/src/org/apache/fop/apps/AWTStarter.java	18 Nov 2002 23:13:30 -0000
@@ -93,7 +93,7 
@@
         renderer.setProgressListener(frame);
         renderer.setComponent(frame);
         driver = 
new Driver();
-        driver.setLogger(log);
+        driver.setLogger(new 
ConsoleLogger(ConsoleLogger.LEVEL_INFO));
         if (errorDump) {
             
driver.setErrorDump(true);
         }

description of change to PrintStarter.java

The 
run() method should look like this:

    public void run() throws FOPException {
        Driver 
driver = new Driver();
        if (errorDump) {
            driver.setErrorDump(true);
        }

        // String 
version = Version.getVersion();   // removed
        // MessageHandler.errorln(version);         // 
removed

        driver.setLogger (new ConsoleLogger(ConsoleLogger.LEVEL_INFO)) ;
        
log.info (Version.getVersion()) ;

        etc. etc. 


Comment 2 Peter B. West 2002-11-19 00:22:05 UTC
Ralph,

fop.app.PrintStarter.java is one of the files that Bernard D'Havé noted as
having line ending problems in Bug 14626.  I am about to clean up all of the
*source files* that he mentioned (thanks to perl).
Comment 3 Ralph LaChance 2002-11-19 17:23:05 UTC
Created attachment 3896 [details]
patch added as attachement (now that lf's are fixed in PrintStarter.java)
Comment 4 Ralph LaChance 2002-11-19 17:24:23 UTC
Now that LF's are fixed in PrintStarter, 
I resubmitted patches to both sources as an attachment.
Comment 5 Christian Geisert 2002-12-09 01:00:42 UTC
Committed, thanks.
Comment 6 Glenn Adams 2012-04-01 07:09:05 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed