Bug 14294 - [PATCH] awt viewer aggregate patch
Summary: [PATCH] awt viewer aggregate patch
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: awt renderer (show other bugs)
Version: trunk
Hardware: Other other
: P3 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-11-06 11:52 UTC by Oleg Tkachenko
Modified: 2012-04-01 07:05 UTC (History)
0 users



Attachments
diff against HEAD (52.27 KB, patch)
2002-11-06 11:54 UTC, Oleg Tkachenko
Details | Diff
new images and resource bundles (9.12 KB, application/octet-stream)
2002-11-06 12:00 UTC, Oleg Tkachenko
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Tkachenko 2002-11-06 11:52:50 UTC
What I did:
o  synchronized the trunk with the branch by adopting up to yesterday
improvements (reloading, go to page dialog l10n, latest czech and german updates
etc.)
o  made l10n implementation using standard java Locale-aware
PropertyResourceBundle facility, converted l10n resources to ascii-encoded
properties files.
o  moved to using real keys for selecting localized strings. I mean
translator.getString("Menu.Go.To.Page") instead of translator.getString("Go to
Page"). While that may look unnecessaryly, usage of keys improves l10n
discipline as it requres from a developer to define each key value at least in
a default bundle, so one never ever will have to look around the code to find
out what labels can be localized in his language.
o cleaned up the code, translated german comments
o superfluous classes to be removed: 
UserMessage, MessageDialog, MessageException - as unused,
SecureResourceBundle, LoadableProperties - in favor of
java.util.ResourceBundle, IconToolBar - in favor of javax.swing.JToolBar,
ProgressListener - as unused (it's a good idea to have formatting progress
listener, but at least it shouldn't be defined in a viewer component),
resources.* and messages.* - in favor new Viewer*.properties.
o a very small adornments, like fop logo in the About dialog etc.
Comment 1 Oleg Tkachenko 2002-11-06 11:54:09 UTC
Created attachment 3754 [details]
diff against HEAD
Comment 2 Oleg Tkachenko 2002-11-06 12:00:28 UTC
Created attachment 3755 [details]
new images and resource bundles
Comment 3 keiron 2002-11-06 14:53:49 UTC
Patch applied to HEAD.
Comment 4 Glenn Adams 2012-04-01 07:05:07 UTC
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed