Bug 58126

Summary:	[patch] acinclude.m4 fix "warning: underquoted definition of ..."
Product:	Apache httpd-2	Reporter:	ohauer <ohauer>
Component:	Build	Assignee:	Apache HTTPD Bugs Mailing List <bugs>
Status:	RESOLVED FIXED
Severity:	normal	Keywords:	FixedInTrunk
Priority:	P2
Version:	2.4-HEAD
Target Milestone:	---
Hardware:	PC
OS:	All
Attachments:	[patch] branches/2.2.x/acinclude.m4 [patch] branches/2.4.x/acinclude.m4 [patch] trunk/acinclude.m4 [patch] branches/2.2.x/buildconf

Description ohauer 2015-07-11 21:04:26 UTC

Created attachment 32899 [details]
[patch] branches/2.2.x/acinclude.m4

Running autoreconf to build http (2.2.x,2,4,x, and trunk) I see complains like the following.

aclocal-1.15: warning: autoconf input should be named 'configure.ac', not 'configure.in'
acinclude.m4:7: warning: underquoted definition of APACHE_HELP_STRING
acinclude.m4:7:   run info Automake 'Extending aclocal'
acinclude.m4:7:   or see http://www.gnu.org/software/automake/manual/automake.html#Extending-aclocal

From automake.html:
Starting with Automake 1.8, aclocal will warn about all underquoted calls to AC_DEFUN.

I've taken the liberty to shape patches against SVN r1690272 (2.2.x, 2.4.x and trunk)

As far as I know also new releases of http 2.2.x should build against apr-1.5.x and apr-util-1.5.x, this is reflected in the buildconf.2.2.x.diff

Comment 1 ohauer 2015-07-11 21:05:13 UTC

Created attachment 32900 [details]
[patch] branches/2.4.x/acinclude.m4

Comment 2 ohauer 2015-07-11 21:05:48 UTC

Created attachment 32901 [details]
[patch] trunk/acinclude.m4

Comment 3 ohauer 2015-07-11 21:06:18 UTC

Created attachment 32902 [details]
[patch] branches/2.2.x/buildconf

Comment 4 Yann Ylavic 2015-10-05 21:05:57 UTC

Thanks, committed in r1706918, and backport proposed (r1706923).

Comment 5 Yann Ylavic 2015-10-06 12:39:26 UTC

Backported to 2.4.17 in r1707038.