Summary: | Fixes to Documentation of JDBC-Based Store | ||
---|---|---|---|
Product: | Tomcat 8 | Reporter: | Fernando Ribeiro <fernando.ribeiro> |
Component: | Documentation | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 8.0.12 | ||
Target Milestone: | ---- | ||
Hardware: | PC | ||
OS: | All |
Description
Fernando Ribeiro
2014-10-26 21:27:44 UTC
(In reply to Fernando Ribeiro from comment #0) > 3- The DDL for the sessions table doesn't match the defaults in the > JDBCStore class [2]: > > CREATE TABLE tomcat$sessions ( > id VARCHAR(100) NOT NULL PRIMARY KEY, > app VARCHAR(255), > data MEDIUMBLOB, > lastaccess BIGINT NOT NULL, > maxinactive INT NOT NULL, > valid CHAR(1) NOT NULL > ); I see no such DDL code as above in JDBCStore class. Where is it from? Did you take the default column names and wrote it by yourself? I would say that the DDL in documentation has more readable column names. It also specifies "KEY kapp_name(app_name)". Is any substantial missing in documented DDL? I wonder whether "MEDIUMBLOB" is specific to MySQL or is actually defined in some specification. > 1- The connectionName and connectionPassword parameters are missing Those have to be documented. Though a better recommendation is to use a DataSource, referenced via dataSourceName property. When a DataSource is used, the "connectionURL", "driverName" properties are no more required. (In reply to Konstantin Kolinko from comment #1) > (In reply to Fernando Ribeiro from comment #0) > > 3- The DDL for the sessions table doesn't match the defaults in the > > JDBCStore class [2]: > > > > CREATE TABLE tomcat$sessions ( > > id VARCHAR(100) NOT NULL PRIMARY KEY, > > app VARCHAR(255), > > data MEDIUMBLOB, > > lastaccess BIGINT NOT NULL, > > maxinactive INT NOT NULL, > > valid CHAR(1) NOT NULL > > ); > > I see no such DDL code as above in JDBCStore class. Where is it from? > Did you take the default column names and wrote it by yourself? Right. > I would say that the DDL in documentation has more readable column names. It > also specifies "KEY kapp_name(app_name)". Is any substantial missing in > documented DDL? They may be more readable but they are not the defaults. The key may really need to be added to my DDL. > I wonder whether "MEDIUMBLOB" is specific to MySQL or is actually defined in > some specification. It is a MySQL data type not available in many other databases. > > 1- The connectionName and connectionPassword parameters are missing > > Those have to be documented. > Though a better recommendation is to use a DataSource, referenced via > dataSourceName property. > > When a DataSource is used, the "connectionURL", "driverName" properties are > no more required. Fixed in 8.0.x for 8.0.15 onwards. |