Summary: | Some memory buglets in AddOutputFilterByType in 2.4.1 | ||
---|---|---|---|
Product: | Apache httpd-2 | Reporter: | Maksim Orlovich <morlovich> |
Component: | mod_filter | Assignee: | Apache HTTPD Bugs Mailing List <bugs> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | Keywords: | PatchAvailable |
Priority: | P2 | ||
Version: | 2.4.1 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: | patch |
Created attachment 28393 [details] patch Hi.. I stumbled on a couple of bugs in handling of AddOutputFilterByType in 2.4.1 when running mod_pagespeed's integration tests against it, which the attached patch should fix: 1) in filter_bytype, there is an off-by-one in writing the null termination of the types array. 2) In add_filter, only one of the ->types or ->expr fields is written, but the structure is allocated without zeroing, so you can end up with a junk value of the other field.