Summary: | GZIP compressed traffic produces errors, when multiple connections allowed | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Kai Mattern <kai.mattern> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 2.5 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Bug Depends on: | |||
Bug Blocks: | 51919 | ||
Attachments: |
Fix to issue
readBuffer local in readResponse() |
Description
Kai Mattern
2011-09-29 15:48:35 UTC
One quick remark: When manually querying the page in question via Firefox, there never is a broken response. Created attachment 27637 [details]
Fix to issue
Hello,
Patch synchronizes methods that modify CookieManager content.
Regards
Philippe
Isn't this the same as Bug 51919? If so, the workround is to disable concurrent downloads. Created attachment 27653 [details]
readBuffer local in readResponse()
the readResponse() in HTTPSampleBase isn't thread safe because there iss this line:
byte[] readBuffer = getThreadContext().getReadBuffer();
The getReadBuffer() (from JMeterContext) is:
A temporary buffer that can be shared between samplers in a thread.
I thinks that it isn't necessary to have a temp share buffer?
I purpose to use a local readBuffer at each call method (patch)
(In reply to comment #4) > Created attachment 27653 [details] > readBuffer local in readResponse() > > the readResponse() in HTTPSampleBase isn't thread safe because there iss this > line: > byte[] readBuffer = getThreadContext().getReadBuffer(); > > The getReadBuffer() (from JMeterContext) is: > A temporary buffer that can be shared between samplers in a thread. > > I thinks that it isn't necessary to have a temp share buffer? It was only there to save recreating it for each sample. > I purpose to use a local readBuffer at each call method (patch) Agreed. In the meantime, the work-round is to avoid using concurrent downloads entirely. As far as I can tell, all such downloads are potentially affected. (In reply to comment #3) > Isn't this the same as Bug 51919? > > If so, the workround is to disable concurrent downloads. It was a manipulation error Also agree with Milamber patch Fixed. URL: http://svn.apache.org/viewvc?rev=1178129&view=rev Log: Bug 51918 - GZIP compressed traffic produces errors, when multiple connections allowed Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterContext.java jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java jakarta/jmeter/trunk/xdocs/changes.xml This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2569 |