| Summary: | GzipInterceptor#decompress is not completly implemented | ||
|---|---|---|---|
| Product: | Tomcat 6 | Reporter: | Christian Stöber <cstoeber> |
| Component: | Cluster | Assignee: | Tomcat Developers Mailing List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cstoeber |
| Priority: | P2 | ||
| Version: | 6.0.29 | ||
| Target Milestone: | default | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: |
Patch file für GzipInterceptor
Patch file for GzipInterceptor, TestGzipInterceptor and TribesTestSuite |
||
There are a number of issues with the patch as currently proposed. - It uses tabs rather than spaces - In includes whitespace changes that add noise - Tests should be provided as JUnit tests in the separate tests directory in the source tree Created attachment 27256 [details]
Patch file for GzipInterceptor, TestGzipInterceptor and TribesTestSuite
Okay. I've checked out Tomcat 6.0.x from subversion in my ecplise and created a new patch through eclipse. For me the patch looks better now.
I've also removed the test code from GzipInterceptor and have written a small JUnit test case.
Thanks for the updated patch. There are still some unnecessary changes in that patch that distract from the changes that fix the problem. Also, new files need to include a license header. I have fixed 7.0.x based on your patch and the fix will be included in 7.0.18 onwards. I have also proposed the fix for 6.0.x. Mark, because it's not desirable and efficient to compress small packages, I've modified the code that it compress only packages with a size greater than 2048 bytes. Should I file a new bug? Or should I send you an new patch? New bug please. This should be user configurable. I'd suggest an attribute name of minCompressionSize Ok, I'll will file a bug. It is user configurable. Based on the compression option in org.apache.coyote.http11.Http11Protocoll I called it compressionMinSize. ;) Fixed in 6.0.x and will be included in 6.0.33 onwards. |
Created attachment 27254 [details] Patch file für GzipInterceptor While testing the GzipInterceptor I was wondering about the strange errors: "Unable to decompress byte contents". At first I thougt, I was using the interceptor in wrong order. But taking a look the source shows a TODO at method decompress: "Fix to create an automatically growing buffer." Because we have session properties which are compressed larger than 2048 bytes, the interceptor didn't work, in our case. I've created a patch. See my attachement.