| Summary: | Percentages not working for provisional-distance-between-starts | ||
|---|---|---|---|
| Product: | Fop - Now in Jira | Reporter: | Eric Amick <eric.amick> |
| Component: | page-master/layout | Assignee: | fop-dev |
| Status: | CLOSED FIXED | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 0.95 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows Vista | ||
| Attachments: |
FO demonstrating bug. The first list uses percentage, the second doesn't.
Let provisional-distance-between-starts act correctly as percentage |
||
Created attachment 24285 [details]
Let provisional-distance-between-starts act correctly as percentage
This is a patch to FOPPropertyMapping.java.
According to standard:
The "provisional-distance-between-start" is specified as a percentage of the inline progression dimension of the closet ancestor block-area.
To its definition in FOPPropertyMapping.java I added the following:
m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH);
I ran the JUNIT tests and no new problems resulted.
I generated the PDF with the new fop.jar and the percentage distances seemed correct.
(In reply to comment #2) > According to standard: > The "provisional-distance-between-start" is specified as a percentage of the > inline progression dimension of the closet ancestor block-area. > To its definition in FOPPropertyMapping.java I added the following: > m.setPercentBase(LengthBase.CONTAINING_BLOCK_WIDTH); > I ran the JUNIT tests and no new problems resulted. > I generated the PDF with the new fop.jar and the percentage distances seemed > correct. Yes. This patch is working perfectly. I have tested the orginal pdabs.fo with provisional-distance-between-start="50%", the space created between elements. Excellent. Fixed in revision 824668: http://svn.apache.org/viewvc?rev=824668&view=rev Thanks for the patch! Vincent batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed |
Created attachment 24256 [details] FO demonstrating bug. The first list uses percentage, the second doesn't. According to the spec, percentages are allowed for provisional-distance-between-starts, but FOP doesn't handle it correctly.