| Summary: | SocketHubAppender in the 1.2.16 does not support a scroll back buffer or application property | ||
|---|---|---|---|
| Product: | Log4j - Now in Jira | Reporter: | Jason Tholstrup <jason.tholstrup> |
| Component: | Appender | Assignee: | log4j-dev <log4j-dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | jason.tholstrup |
| Priority: | P2 | ||
| Version: | 1.2 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Attachments: | Patch to fix the issues listed in the description | ||
This patch looks good to me, I can't see any reason not to apply it. Scott? any final comments? Looks good to me as well. Thanks for the contribution Jason Patch applied as of revision 634545. Thanks muchly. Can we presume that the Apache Contributor Agreement has been signed and is on file at the foundation? Jake I thought that if a person attached their contribution to bugzilla that was implied donation to Apache? I agree with Paul..I don't think a CLA is required for submitted patches. My misunderstanding. From http://www.apache.org/licenses/ ... "The ASF desires that all contributors of ideas, code, or documentation to the Apache projects complete, sign, and submit (via postal mail, fax or email) an Individual Contributor License Agreement (CLA) [PDF form]." Looks like it isn't "required", but "desired" for general contributors. However, for committers it is required... "A signed CLA is required to be on file before an individual is given commit rights to an ASF project." Sorry for the noise. Jake |
Created attachment 21644 [details] Patch to fix the issues listed in the description Part 1) The 1.3 version of SocketHubAppender uses a cyclic buffer to store the last X log messages that are delivered to the client on connection so that they can have some of the recently logged events. This was never back ported to the 1.2.X branch. Part 2) The 1.2.X version of SocketAppender supports an application property which chainsaw can read to specify which application the log is for. SocketHubAppender should also support this functionality. The attached patch resolves these issues. Thanks to Scott Deboy for his guidance.