Summary: | Memory Leak when closing test plan | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | Jaroslav Bachorik <Jaroslav.Bachorik> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | major | ||
Priority: | P2 | ||
Version: | 2.3.1 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
Attachments: | Should fix memory leak when closing test plans |
Description
Jaroslav Bachorik
2007-12-04 16:35:55 UTC
Created attachment 21231 [details]
Should fix memory leak when closing test plans
Plz, review the patch whether it doesn't affect other functionality
Thanks very much - the patch looks good. {I like the way you moved the clearTestPlan() call into GuiPackage. Neat.) Unit testing shows a problem with the AbstractListener patch - clone() causes an NPE. However, that is easy to fix, just use: clone.listener=this.listener; instead of: clone.setListener(getVisualizer()); [clone() should probably have been coded that way originally.] I'll try some more tests and apply the patch if all goes well. Seems to work OK, so added to SVN in r601473. Had to make one more change, as the listener may not be present: protected final Visualizer getVisualizer() { if (listener == null){ // e.g. in non-GUI mode return null; } return (Visualizer)listener.get(); This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2052 |