Summary: | [PATCH] AFP Renderer - output resolution control | ||
---|---|---|---|
Product: | Fop - Now in Jira | Reporter: | Adrian Cumiskey <dev> |
Component: | general | Assignee: | fop-dev |
Status: | CLOSED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | trunk | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | other | ||
Attachments: |
patch file
patch file |
Description
Adrian Cumiskey
2007-08-06 03:35:04 UTC
Created attachment 20601 [details]
patch file
Created attachment 20612 [details]
patch file
This patch supersedes the previous one. I discovered a subversion merge
problem on AFPRenderer.java which is now fixed.
I've got a question for those who use AFP: Adrian introduced a renderer-resolution setting. All the other renderers use target-resolution [1]. Since the AFP renderer's default resolution is 240dpi instead of 72 dpi like for the other renderers. Switching to target-resolution would decrease the output quality for those who use the AFP renderer at its default settings. But introducing renderer-resolution adds a third resolution setting which could lead to confusion. Should we perhaps let each renderer try to give the user agent its default target resolution? Opinions? Ideas? [1] http://xmlgraphics.apache.org/fop/0.94/configuration.html#general-elements Never mind my previous question. Looks like there was already a discussion: http://marc.info/?l=fop-dev&m=118597659210348&w=2 Patch applied with modification: Bugfix: SVGs were rendered in the wrong size when the target-resolution and the renderer-resolution differ. http://svn.apache.org/viewvc?rev=582131&view=rev Adrian, thanks for the patch! I know I once asked you to install Checkstyle and you took that to heart, but I'd be grateful if you wouldn't do too much Checkstyle cleanup as part of a patch. It makes it difficult to spot the actual modifications in all the differences. batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed |