Summary: | View Result in Table should use colors | ||
---|---|---|---|
Product: | JMeter - Now in Github | Reporter: | glhez <glhez> |
Component: | Main | Assignee: | JMeter issues mailing list <issues> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | other | ||
Attachments: |
Suggested patch
Suggested patch |
Description
glhez
2006-05-31 16:29:02 UTC
Created attachment 19729 [details]
Suggested patch
This suggested patch uses the very nice icon for success and failure which is
used in the "View Result Tree" visualizer. I think those two images makes it a
lot easier to see what is a failure.
I haven't changed it with this patch, but I was thinking that the column
heading name should be renamed from "Success?" to "Success" or I prefer
"Status".
I'll supply a bit larger patch in a few minutes, which also adds a column to
show the number of assertions that failed or passed, I think that can be
useful.
Created attachment 19730 [details]
Suggested patch
This patch adds uses image for success or failure, and also adds a column named
"Assertions", which shows how many assertions were ok, and how many failed.
If no assertions are present, no value is displayed in the column.
It is tempting to set the size of the different columns, since some are too
wide. But that will happen in another bugzilla entry, if it happens.
I've added the first patch. I'm not convinced that it is useful to know how many Assertions passed/failed. If it is decided to add this, then some more thought needs to be given to internationalisation; e.g. by using a message formatter string rather than building it up as proposed. Alternatively use separate columns for the counts. It is OK that you only added the first patch. I'm thinking about adding a "Configure" button, similar to the "Configure" button for logging to file, to allow the user to specify which columns he wants. And then we could add two columns, one for number of assertions that failed, and for number of assertions that passed. I think this bug should be closed as "fixed". The display of the image icon for success / failure makes it visible enough which rows failed and which ones passed. This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/1733 |