Summary: | invalidated session causes pageContext methods to fail | ||
---|---|---|---|
Product: | Tomcat 6 | Reporter: | Pierre Delisle <pierre.delisle> |
Component: | Jasper | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nex_sandro |
Priority: | P3 | ||
Version: | 6.0.18 | ||
Target Milestone: | default | ||
Hardware: | Other | ||
OS: | other |
Description
Pierre Delisle
2005-12-16 01:58:15 UTC
*** Bug 37699 has been marked as a duplicate of this bug. *** In the future, please attach patches from GlassFish rather than inlining them. As it is, I can't do anything about this since I've already seen the patch, so I'm tainted from an IP persective. Before this patch can be accepted, we need to know that your submission is covered by a CCLA. Otherwise, Sun owns the code, so it can't be incorporated into Tomcat. Hi William, Thanks for looking into this so quickly. The situation is the same as the one you encountered with Kin-Man on bug 35351: >> Just to be clear, is this patch is still covered by your CCLA? In English, is >> this a grant from glassfish to that ASF? >> > This is just a patch, and there is no license or copyright, so YES. Let me know if you need anything else. (In reply to comment #3) > Hi William, > Thanks for looking into this so quickly. > The situation is the same as the one you encountered > with Kin-Man on bug 35351: > >> Just to be clear, is this patch is still covered by your CCLA? In English, is > >> this a grant from glassfish to that ASF? > >> > > This is just a patch, and there is no license or copyright, so YES. > Let me know if you need anything else. I accepted Kin-Man's patch based on the fact that he is a Tomcat committer, and as such should have a CCLA on file with the ASF. If that is still valid, than that means that Sun has trusted him with deciding about donating Sun code to the ASF. Were I to find out that Kin-Man's CCLA has been revoked, I would revert the commit in a heart-beat :). IANAL, but from all of the ASF lists that I have followed, the above reasoning doesn't even hold a drop of water. So again I ask if you have a CCLA on file so that the ASF can accept your donation of Sun's code? The patch is nice, so I'm hoping that you say yes ;-). With very minor style changes, your patch has been committed to SVN trunk, and will appear in 5.5.15. Thanks much! It seems the problem still exists in the Tomcat 6.0.18. Moreover, I took a look at the PageContextImpl.java class and I do not see there any fixes related to this bug. I browsed svn repository and it looks like this commit has reverted the fix: http://svn.apache.org/viewvc/tomcat/jasper/tc6.0.x/src/share/org/apache/jasper/runtime/PageContextImpl.java?view=log Is it supposed to be so? Or fix was reverted by mistake? Moving to Tomcat 6 Thanks for the report and the research. This has been fixed in trunk and proposed for 6.0.x This has been fixed in 6.0.x and will be included in 6.0.20 onwards. |