Summary: | No error reported when <jsp:include> has non-existent target | ||
---|---|---|---|
Product: | Tomcat 5 | Reporter: | Steve Kirk <apache-bug-db> |
Component: | Servlet & JSP API | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 5.5.12 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Attachments: |
example war file
tomcat.log using log4j with DEBUG level for ApplicationDispatcher |
Description
Steve Kirk
2005-11-01 22:59:43 UTC
Created attachment 16849 [details]
example war file
I'm looking at org.apache.catalina.core.ApplicationDispatcher (which I think is the relevant class), and it seems to log and re-throw all the exceptions. Steve, can you please retry it on 5.5.12 with DEBUG-level logging enabled for this class, and post your findings when you get a chance? Thanks. (In reply to comment #2) OK have done that. Used fresh install of TC5.5.12 installed as windows service using the service.bat script (which is my standard dev setup). TC is unmodified from standard install, except that I added my test.war (attached) to the webapps folder. No other changes to standard setup. PS am using jdk 1.5.0_02-b09 For some reason could not get DEBUG/ALL logging of the class to work with java.util.logging (which is what I normally use), so installed log4j instead exactly as described on the logging docs page (at http://tomcat.apache.org/tomcat-5.5-doc/logging.html), with the exception that I modified log4j.properties as shown below to give DEBUG level on the ApplicationDispatcher, hope this is correct, not sure as do not know log4j well: log4j.rootLogger=info, R log4j.appender.R=org.apache.log4j.RollingFileAppender log4j.appender.R.File=${catalina.home}/logs/tomcat.log log4j.appender.R.MaxFileSize=10MB log4j.appender.R.MaxBackupIndex=10 log4j.appender.R.layout=org.apache.log4j.PatternLayout log4j.appender.R.layout.ConversionPattern=%p %t %c - %m%n log4j.logger.org.apache.catalina.core.ApplicationDispatcher=DEBUG Then ran the request to http://localhost:8080/test/ to test the attached war. Page worked fine as before, no reported errors in logfile or browser, despite one of the included files being missing from the webapp. The entire contents of the resulting tomcat.log are attached. Hope this helps, just let me know if you need anything else. Created attachment 17073 [details]
tomcat.log using log4j with DEBUG level for ApplicationDispatcher
Steve, thank you. This helps. I'll try to find more time to look at this within the next few days. Ooops, I guess I didn't get to this in a few days, did I? It's piqued my curiosity again. Thanks for going through the debugging steps and attaching the WAR. Your log4j configuration looks fine. I'll try to run an instrumented version of the code locally with more logging statements and see if I can learn anything. This has been fixed in 5.5.x and 6.0.x and will be included in the next releases of each. Is it possible to disable this behavior with configuration? I love the addition of this error, but I don't want to have to update legacy versions of my app. I am afraid not. |