Summary: | [PATCH] Chunked transfer encoding for IIS JK/ISAPI | ||
---|---|---|---|
Product: | Tomcat Connectors | Reporter: | Tim Whittington <Tim.Whittington> |
Component: | Common | Assignee: | Tomcat Developers Mailing List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Attachments: |
Chunked encoding patch for JK/ISAPI
Chunked encoding patch for JK/ISAPI |
Description
Tim Whittington
2005-06-09 22:30:32 UTC
Created attachment 15357 [details]
Chunked encoding patch for JK/ISAPI
Patch against jk_isapi_plugin.c r1.49
The complexity of your patch it too big to be considered as bug. Something like that should be considered for the 1.3 branch. The current implementation works fine for the majority of the users. I've improved this functionality a bit - mostly tweaking and adding some of the HTTP/1.1 edge cases for enabling chunked encoding. I won't repatch until JK 1.3 is branched, as there's no roadmap for that at the moment. I'm still maintaining this against the head of JK for my customers, and still waiting for JK 1.3 (two years and counting). The IIS connector without chunked encoding is pretty much useless for high volume sites (I've had customers completely exhaust the TCP ports on a Windows Server because of the lack of reuse, even with the TCP params tweaked up). Created attachment 21551 [details]
Chunked encoding patch for JK/ISAPI
I've updated the patch against head following discussions with Rainer and
Mladen on the dev list.
This patch separates out all chunk encoded behaviour based on whether chunk
encoding is enabled for the redirector (in the case of response writes this is
a flag on the private date object for the request).
I've tested this on IIS 6.0 and 5.1 with chunk encoding enabled and disabled.
There are a couple of minor variances from trunk behaviour here:
- I've disabled SF_NOTIFY_AUTH_COMPLETE for IIS 5.1 (copied from my patchset),
as I've never found a 5.1 it didn't break OPTIONS/PUT etc. on.
- The basic response write code has been reworked into isapi_write_client so it
can be reused for the chunked encoding on IIS 5 (vector writes are used for 6).
Chunked encoding support for the ISAPI redirector has been added in the meantime. (In reply to Rainer Jung from comment #6) > Chunked encoding support for the ISAPI redirector has been added in the > meantime. To be specific: it was r701029 and r704677 (and maybe others in October 2008), included in 1.2.27 onwards. |