Create Ticket
Warning Can't synchronize with repository "(default)" (Couldn't open Subversion repository /x1/svn/asf/bloodhound: SubversionException: ("Expected FS format between '1' and '4'; found format '6'", 160043)). Look in the Trac log for more information.

Reporter:
olemis  
Opened:
Type:
enhancement  
Status:
closed : fixed  
Priority:
major  
Milestone:
Component:
Version:
 
Description (last modified by olemis) (diff)

All views related to the repository (e.g. browser, changesets, log ... ) still have legacy styles . They have to be converted to bootstrap.

Cc:
 

Attachments

bh_theme_x_73_revlog.png (72.3 KB) - added by olemis 19 months ago.
Screenshot #162 : Revision log
t162_r1394017_bootstrap_revlog.diff (16.8 KB) - added by olemis 19 months ago.
Patch: BH Theme #162 : Convert revision log web UI to Bootstrap styling
bh_theme_x_78_file_preview.png (55.8 KB) - added by olemis 18 months ago.
Screenshot #162 : File preview in repository browser
bh_theme_x_83_dir_list.png (111.6 KB) - added by olemis 18 months ago.
Screenshot #162 : Directory listing in repository browser
bh_theme_x_84_repos_index.png (109.2 KB) - added by olemis 18 months ago.
Screenshot #162 : Repository index
t162_r1398842_bootstrap_revlog.diff (16.8 KB) - added by olemis 18 months ago.
Patch: BH Theme #162 : Convert revision log web UI to Bootstrap styling
t162_r1398842_bootstrap_browser.diff (26.5 KB) - added by olemis 18 months ago.
Patch: BH Theme #162 : Convert repository browser web UI to Bootstrap styling
t162_r1398842_bootstrap_revgraph.diff (2.3 KB) - added by olemis 18 months ago.
Patch: BH Trac #162 : Rules for revision log to match position of revision graph
t162_r1433074_bootstrap_revlog.diff (17.0 KB) - added by olemis 15 months ago.
Patch: BH Theme #162 : Convert revision log web UI to Bootstrap styling
t162_r1433074_bootstrap_browser.diff (26.7 KB) - added by olemis 15 months ago.
Patch: BH Theme #162 : Convert repository browser web UI to Bootstrap styling
t162_r1433074_bootstrap_revgraph.diff (2.4 KB) - added by olemis 15 months ago.
Patch: BH Trac #162 : Rules for revision log to match position of revision graph

Download all attachments as: .zip


Change History

olemis

  • Description modified (diff)

jdreimann

  • Owner changed from nobody to jdreimann
  • Status changed from new to assigned

I'll have a look into this to come up with suggestions as to what they may look like.

jdreimann

  • Owner jdreimann deleted

olemis

Screenshot #162 : Revision log

olemis

Patch: BH Theme #162 : Convert revision log web UI to Bootstrap styling

olemis

Attached patch implements a proposal to convert revision log web UI to Bootstrap styling . After applying it against theme plugin @ r1394017 it will look like this

Screenshot #162 : Revision log

It's very similar to Trac 's . Notice that

  1. File path moved to breadcrumbs nav area
  2. Size of long paths is controlled by including some paths items in a drop down menu . This is necessary because repository depth may be arbitrary but there's limited space in the UI .
  3. It's not possible to copy full path . I've read this is a requirement considered by Trac . I was thinking of including a tiny control in breadcrumbs for this purpose .

Feedback appreciated .

olemis

  • Owner set to olemis
  • Status changed from assigned to accepted

olemis

Screenshot #162 : File preview in repository browser

olemis

Today I started conversion to Bootstrap of repository browser file preview . Proposed interface looks like shown below

Screenshot #162 : File preview in repository browser

The lines in file contents area have been introduced as a side effect of work previously committed for #88 . They should be removed by applying the following tiny update

  • bhtheme/theme.py

    $ hg diff
    diff -r cc1f958d80ae bhtheme/theme.py
    a b  
    122122        """Insert default Bootstrap CSS classes if rendering  
    123123        legacy templates (i.e. determined by template name prefix). 
    124124        """ 
     125        if filename.startswith('bh_'): 
     126            return stream; 
    125127        tx = Transformer('body') 
    126128 
    127129        def add_classes(classes): 

Isn't it about time to commit this modification ?

Any other comments | suggestions are welcome .

olemis

Screenshot #162 : Directory listing in repository browser

olemis

Screenshot #162 : Repository index

olemis

I have refreshed the patch for repository browser to incorporate CSS styles for directory listings

Screenshot #162 : Directory listing in repository browser

... and repository index

Screenshot #162 : Repository index

Feedback is welcome .

olemis

Patch: BH Theme #162 : Convert revision log web UI to Bootstrap styling

olemis

Patch: BH Theme #162 : Convert repository browser web UI to Bootstrap styling

olemis

Patch: BH Trac #162 : Rules for revision log to match position of revision graph

olemis

I refreshed all previous patches mainly in spite of aligning changeset rows in revision log next to the corresponding indicator in revision graph . Patch order listed below

$ hg qapplied
t162/t162_r1398842_bootstrap_revlog.diff
t162/t162_r1398842_bootstrap_browser.diff
t162/t162_r1398842_bootstrap_revgraph.diff

olemis

  • Owner changed from olemis to gjm
  • Status changed from accepted to review

gjm

  • Milestone changed from Release 4 to Release 5

Moving in-progress tickets to the Release 5 milestone. Developers should reschedule the ticket if it won't be completed for the next release.

olemis

Patch: BH Theme #162 : Convert revision log web UI to Bootstrap styling

olemis

Patch: BH Theme #162 : Convert repository browser web UI to Bootstrap styling

olemis

Patch: BH Trac #162 : Rules for revision log to match position of revision graph

olemis

I have refreshed patches for this ticket

rjollos

  • Owner changed from gjm to rjollos

olemis

@rjollos : now I don't recall whether I implemented blame support into these templates . Could you please check ?

rjollos

Sure, I will check. I've started work on this ticket today.

rjollos

(In [1452706])

Refs #162: Applied t162_r1433074_bootstrap_revlog.diff from Olemis. Some additional span12 classes were applied to align elements. Additional patches will be applied on top of this one.

rjollos

(In [1453168])

Refs #162: Applied patch t162_r1433074_bootstrap_browser.diff from Olemis, with modifications to keep elements contained within the #content div.

rjollos

(In [1453170])

Refs #162: Applied patch t162_r1433074_bootstrap_revgraph.diff from Olemis.

rjollos

  • Resolution set to fixed
  • Status changed from review to closed

Thanks to this nice work by Olemis, the repository browsers and revision log seem to be in pretty good shape. I don't see any major issues at the moment, and refinements can be discussed for the next release. We still need a Bootstrap template for the changeset view. I don't foresee having time do that before Release 5, so I'm closing this for now.


(In [1453194])

Refs #162: Updated release notes.

Note: See TracTickets for help on using tickets.

Activity

  

Warning   No events reported for enhancement: Convert version control user interface to Bootstrap (closed: fixed) in the last 30 days since Apr 21, 2014. This may happen if system is not configured correctly. Please contact your administrator if you think this is the case.