Bug 7108 - sa_update fails: config: invalid regexp for rule __PDS_FROM_2_EMAILS
Summary: sa_update fails: config: invalid regexp for rule __PDS_FROM_2_EMAILS
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.4.0
Hardware: PC Linux
: P2 blocker
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-26 20:31 UTC by Craig Shaver
Modified: 2014-11-27 18:59 UTC (History)
1 user (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Shaver 2014-11-26 20:31:41 UTC
New rule for __PDS_FROM_2_EMAILS breaks sa-update run as of 11/26/2014

========== sa-update cron run ==========
/etc/cron.daily/zzz-sa-update.cron:

Update available for channel updates.spamassassin.org: 1641165 -> 1641542
http: (curl) GET http://spamassassin.apache.org/updates/MIRRORED.BY, success
http: (curl) GET http://www.sa-update.pccc.com/1641542.tar.gz, success
http: (curl) GET http://www.sa-update.pccc.com/1641542.tar.gz.sha1, success
http: (curl) GET http://www.sa-update.pccc.com/1641542.tar.gz.asc, success
config: invalid regexp for rule __PDS_FROM_2_EMAILS: /^\W+([\w+.-]+\@[\w.-]+\.\w\w++)(?:[^\n\w<]{0,80})?<(?!\1)[^\n\s]*\@/i: Nested quantifiers in regex; marked by <-- HERE in m/(?i)^\W+([\w+.-]+\@[\w.-]+\.\w\w++ <-- HERE )(?:[^\n\w<]{0,80})?<(?!\1)[^\n\s]*\@/

channel: lint check of update failed, channel failed
Update failed, exiting with code 4
Spamassassin rules update completed.
Spamassassin restarted.
========== sa-update cron run ==========

{443}root:gateway:~craig/work/dev/spam/saupdate> grep __PDS_FROM_2_EMAILS *.cf
72_active.cf:meta    PDS_FROM_2_EMAILS       __PDS_FROM_2_EMAILS && !__VIA_ML && !__VIA_RESIGNER
72_active.cf:header  __PDS_FROM_2_EMAILS     From =~ /^\W+([\w+.-]+\@[\w.-]+\.\w\w++)(?:[^\n\w<]{0,80})?<(?!\1)[^\n\s]*\@/i

Spamassassin 3.4.0, perl 5.8.8, CentOS 5.x (up to date)
{445}root:gateway:~craig/work/dev/spam/saupdate> uname -a
Linux gateway.myittybitty.com 2.6.18-398.el5 #1 SMP Tue Sep 16 20:50:52 EDT 2014 x86_64 x86_64 x86_64 GNU/Linux
Comment 1 John Hardin 2014-11-26 20:40:05 UTC
This only occurs on perl < 5.10, the ++ syntax was introduced in 5.10

This rule has been commented out in the sandbox, hopefully it will go out tonight or the next night.

See also Bug 7107
Comment 2 John Hardin 2014-11-27 18:59:31 UTC
Restored with perl_version protection, revision 1642208