Bug 7077 - UNPARSEABLE_RELAY false positives
Summary: UNPARSEABLE_RELAY false positives
Status: RESOLVED INVALID
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.4.0
Hardware: Other Linux
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-17 18:10 UTC by Kevin Fenzi
Modified: 2014-08-21 21:50 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Fenzi 2014-08-17 18:10:27 UTC 
Given the following email: 

Received: from testserver.rhsoft.net (testserver.vmware.local [192.168.196.12])→(using TLSv1.2
→       with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))→(No client certificate requested)
→       by srv-rhsoft.rhsoft.net (MTA) with ESMTPS id 3hX1hV2qLWzBqRl
→       for <rhsoft@test.rh>; Mon, 11 Aug 2014 17:44:58 +0200 (CEST)
Received: from rh.thelounge.net (unknown [91.118.73.99])→       (using TLSv1.2
→       with cipher ECDHE-RSA-AES256-SHA (256/256 bits))→       (No client certificate requested)
→       by testserver.rhsoft.net (MTA) with ESMTPSA id 3hX1hT05Lmz29MX
→       for <rhsoft@test.rh>; Mon, 11 Aug 2014 17:44:56 +0200 (CEST)
Message-ID: <53E8E4F8.6080807@testserver.rhsoft.net>
Date: Mon, 11 Aug 2014 17:44:56 +0200
From: "Reindl Harald (Testserver)" <test@testserver.rhsoft.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.0
MIME-Version: 1.0
To: rhsoft@test.rh
Subject: Test

The UNPARSEABLE_RELAY rule is triggered. The relays should be valid, so perhaps the test could be updated to handle this pretty common case?

Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1128364
Comment 1 AXB 2014-08-17 18:49:43 UTC 
FTR: 
score UNPARSEABLE_RELAY 0.001
Comment 2 Karsten Bräckelmann 2014-08-17 20:10:31 UTC 
(In reply to Kevin Fenzi from comment #0)
> The UNPARSEABLE_RELAY rule is triggered.

No, it is not.

> Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1128364

Running RH bug 1128364 attachment 925821 through spamassasin yields exactly one rule triggered: ALL_TRUSTED

Moreover, grepping -D debug output for X-Spam-Relays-* metadata headers shows both Received headers being parsed correctly.

Closing RESOLVED INVALID.

Probably a duplicate of bug 6103. This most likely is an issue with spamass-milter generating a broken fake header, or missing milter macros.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510665


Loosely related:

In the RH bug the reporter states "the spamass version should not be in the headers by default".

This is just wrong. The X-Spam-Checker-Version header is always added and cannot be removed by the remove_header or clear_headers options. The M::SA::Conf docs clearly state this, explaining the reason.

The reporter's clear_headers and duplicated add_header configuration does not work as intended, he still gets the Version header added.
Comment 3 Karsten Bräckelmann 2014-08-21 21:39:40 UTC 
> Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1128364

Kevin, just a reminder to close that RH bug. It still is open and assigned to you.
Comment 4 Kevin Fenzi 2014-08-21 21:50:34 UTC 
Yes, I am aware.