Bug 6725 - WARNING: 'endif' without 'if'/'ifplugin' conditional on rules thrown during nightly cron
Summary: WARNING: 'endif' without 'if'/'ifplugin' conditional on rules thrown during n...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: PC Windows 7
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-13 17:06 UTC by Kevin A. McGrail
Modified: 2011-12-15 17:29 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Cron Output for do-stable-update-with-scores on zones application/zip None Kevin A. McGrail [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin A. McGrail 2011-12-13 17:06:57 UTC 
I believe a rules file is throwing a WARNING: 'endif' without 'if'/'ifplugin' conditional during the nightly builds.

Need to check on this on tonight's build and see if we can narrow down the issue.
Comment 1 Kevin A. McGrail 2011-12-14 23:07:23 UTC 
Created attachment 5020 [details]
Cron Output for do-stable-update-with-scores on zones

do-stable-update-with-scores on zones is still throwing the endif error.  Anyone have any ideas on how to track it down?

I tried running spamassassin --lint  -p on every cf file in sandboxes and spamassassin --lint  -C rules on trunk. 

No ideas on what's throwing the error.  Someone got some time to dig into this one?
Comment 2 mykel 2011-12-15 04:27:45 UTC 
The warning only shows for the 3.3.2 and 3.3.3 releases.  Prior to 3.3.2, the mkrules script didn't check for this error in the .cf files, so even though it was present earlier, it is not reported.

The actual error is in the rulesrc/sandbox/emailed/99_alex_dev.cf.  That file is no longer in the current trunk, which is why you couldn't find it with a lint.

The warning is thrown as the older versions are built ready to be used to check the new rules update - they are not part of the actual current rules update check.

I guess you either need to live with these warnings or modify the mkupdate-with-scores script to specifically hide this known warning during the build of old versions.
Comment 3 Kevin A. McGrail 2011-12-15 17:29:53 UTC 
Fixed the bug in 3.3 trunk and will live with the error if this doesn't resolve it.

svn commit -m 'too many endifs - bug 6725'
Sending        emailed/99_alex_dev.cf
Transmitting file data .
Committed revision 1214881.

Thanks very much for the research.  I was annoyed I couldn't find it!