Bug 6720 - 72_active.cf lacks ifplugin for spamhaus DNSBL rule
Summary: 72_active.cf lacks ifplugin for spamhaus DNSBL rule
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.3.2
Hardware: PC Linux
: P2 blocker
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-12 11:44 UTC by Pandu E Poluan
Modified: 2013-01-20 17:40 UTC (History)
3 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Patch for 72_active.cf application/octet-stream None Pandu E Poluan [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pandu E Poluan 2011-12-12 11:44:59 UTC 
Created attachment 5017 [details]
Patch for 72_active.cf

I keep failing initial sa-update (fresh installation) with all plugins disabled, with the following error message:

config: failed to parse line, skipping, in "/tmp/.spamassassin159920p2UgPtmp/72_active.cf": uridnsbl        URIBL_SBL_A    sbl.spamhaus.org.   A
channel: lint check of update failed, channel failed

Uncommenting the following line in local.cf fixes the error:

loadplugin Mail::SpamAssassin::Plugin::URIDNSBL

An investigation shows that the URIBL_SBL_A rule (for spamhaus) has no "ifplugin...endif" around it, when compared to the URIBL_RHS_DOB rule just preceding it.

Attached is a patch (tested -- no more lint check failure) that I whup up to fix this issue.
Comment 1 AXB 2011-12-12 12:09:07 UTC 
(In reply to comment #0)
> Created attachment 5017 [details]
> Patch for 72_active.cf
> 
> I keep failing initial sa-update (fresh installation) with all plugins
> disabled, with the following error message:
> 
> config: failed to parse line, skipping, in
> "/tmp/.spamassassin159920p2UgPtmp/72_active.cf": uridnsbl        URIBL_SBL_A   
> sbl.spamhaus.org.   A
> channel: lint check of update failed, channel failed
> 
> Uncommenting the following line in local.cf fixes the error:
> 
> loadplugin Mail::SpamAssassin::Plugin::URIDNSBL
> 
> An investigation shows that the URIBL_SBL_A rule (for spamhaus) has no
> "ifplugin...endif" around it, when compared to the URIBL_RHS_DOB rule just
> preceding it.
> 
> Attached is a patch (tested -- no more lint check failure) that I whup up to
> fix this issue.

next sa-update run should fix this
Comment 2 Kevin A. McGrail 2011-12-12 15:25:07 UTC 
> next sa-update run should fix this

Hmm, I am worried that this isn't complete enough.  The type was added only in 3.4.0 aka trunk.  You need to add a version block as well.

if (version >= 3.200000)

endif
Comment 3 AXB 2011-12-12 15:27:45 UTC 
(In reply to comment #2)
> > next sa-update run should fix this
> 
> Hmm, I am worried that this isn't complete enough.  The type was added only in
> 3.4.0 aka trunk.  You need to add a version block as well.
> 
> if (version >= 3.200000)
> 
> endif

had set:
tflags          URIBL_SBL_A    net a nopublish

so far I see no value in this rule... total overlap with URIBL_SBL
am watcing on trap boxes...
Comment 4 Kevin A. McGrail 2013-01-20 17:40:27 UTC 
Resolved.