Bug 6696 - Add URIBL SBL lookup to check A record of domain using new "net a"
Summary: Add URIBL SBL lookup to check A record of domain using new "net a"
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (Eval Tests) (show other bugs)
Version: unspecified
Hardware: All All
: P2 normal
Target Milestone: 3.4.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 13:57 UTC by AXB
Modified: 2011-12-10 14:30 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
URIBL_SBL_A application/octet-stream None AXB [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description AXB 2011-11-08 13:57:04 UTC 
SA 3.4.0 provides to check if a URI's A record is listed on, for example SBL


uridnsbl        URIBL_SBL_A    sbl.spamhaus.org.   A
body            URIBL_SBL_A    eval:check_uridnsbl('URIBL_SBL_A')
describe        URIBL_SBL_A    Contains a URL's A record listed in the SBL blocklist
tflags          URIBL_SBL_A    net a

This may overlap with URIBL_SBL

rule will be placed in sandbox for masschecks
Comment 1 AXB 2011-11-08 14:01:28 UTC 
Created attachment 5008 [details]
URIBL_SBL_A
Comment 2 Kevin A. McGrail 2011-11-08 19:24:37 UTC 
Alex, 

Aside, I updated your Bugzilla account to reflect that you have a CLA.

I added 20_bug_6996.cf to my sandbox and did a make test.

It currently fails lint:

lint: config: failed to parse line, skipping, in "rules/70_sandbox.cf": uridnsbl        URIBL_SBL_A    sbl.spamhaus.org.   A at build/mkrules line 254.
lint: config: failed to parse line, skipping, in "rules/70_sandbox.cf": uridnsbl        URIBL_SBL_A    sbl.spamhaus.org.   A at build/mkrules line 254.

I looked at the plug in and the tflag for a is defined in URIDNSBL.pm but it looks like mkrules in build will need code added for this new rule type.
Comment 3 Mark Martinec 2011-11-09 14:02:14 UTC 
trunk:

Bug 6696: Add URIBL SBL lookup to check A record of domain using new "net a"
  - load URIDNSBL plugin for lint, reinstate the URIBL_SBL_A rule
  Sending build/mkrules
  Sending rulesrc/sandbox/axb/20_bug_6696.cf
Committed revision 1199762.
Comment 4 Kevin A. McGrail 2011-11-09 14:37:23 UTC 
I marked a rule net c and it passes make test.  Should that be expected?
Comment 5 Mark Martinec 2011-11-09 14:46:22 UTC 
> I marked a rule net c and it passes make test.  Should that be expected?

I guess so.

The list of tflags options may be extended by plugins, so I don't think
we have a definite list of valid tflags, nor do we have a test for them.
I think the concept of 'ignore unknown tflags options' is acceptable.
Comment 6 Kevin A. McGrail 2011-12-10 14:25:50 UTC 
Can this bug be marked closed?
Comment 7 AXB 2011-12-10 14:29:42 UTC 
(In reply to comment #6)
> Can this bug be marked closed?

+1
Comment 8 Kevin A. McGrail 2011-12-10 14:30:23 UTC 
Considered resolved and leaving the rules to masscheck...