Bug 6626 - Newer MySQL chokes on TYPE=MyISAM syntax
Summary: Newer MySQL chokes on TYPE=MyISAM syntax
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 3.3.2
Hardware: PC All
: P2 normal
Target Milestone: 3.4.0
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 17:44 UTC by Mark Martinec
Modified: 2011-09-21 00:29 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status
docs change: prefer BayesStore::MySQL over BayesStore::SQL patch None Mark Martinec [HasCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Martinec 2011-06-23 17:44:22 UTC
Newer version of MySQL throw a syntax error when bayes_mysql.sql schema
is applied. The offending part is the 'TYPE=MyISAM':

  ERROR 1064 (42000): You have an error in your SQL syntax; check the manual
  that corresponds to your MySQL server version for the right syntax to use
  near 'TYPE=MyISAM'

It is also becoming a FAQ telling newcomers that they'd better be
using the Mail::SpamAssassin::BayesStore::MySQL storage engine with
InnoDB, instead of a generic Mail::SpamAssassin::BayesStore::SQL.

Proposed is a documentation change to README.bayes to talk
about BayesStore::MySQL first and about BayesStore::SQL second;
and to replace TYPE=MyISAM with ENGINE=InnoDB in schemas and
document how to change it back if necessary.
Comment 1 Mark Martinec 2011-06-23 17:49:33 UTC
Created attachment 4927 [details]
docs change: prefer BayesStore::MySQL over BayesStore::SQL

trunk:
  Bug 6626: Newer MySQL chokes on TYPE=MyISAM syntax' ci 
Sending  sql/README.bayes
Sending sql/awl_mysql.sql
Sending sql/bayes_mysql.sql
Committed revision 1139015.


(also changes awl.email data type from varchar to varbinary
 -related to Bug 6625)
Comment 2 Mark Martinec 2011-09-21 00:29:31 UTC
closing, fixed for 3.4