6543 – Numerous 'score set for non-existent rule' in the currently published rules.

Bug 6543 - Numerous 'score set for non-existent rule' in the currently published rules.

Summary: Numerous 'score set for non-existent rule' in the currently published rules.

Status:	RESOLVED FIXED

Alias:	None

Product:	Spamassassin
Classification:	Unclassified
Component:	sa-update (show other bugs)
Version:	3.3.1
Hardware:	All All

Importance:	P2 major
Target Milestone:	Undefined
Assignee:	SpamAssassin Developer Mailing List

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-16 05:22 UTC by Steve Freegard
Modified:	2011-11-01 23:27 UTC (History)
CC List:	5 users (show)

Attachment	Type	Modified	Status	Actions	Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Steve Freegard 2011-02-16 05:22:04 UTC

On a fresh installation I'm seeing 19 of these after running an sa-update:

for i in `spamassassin -D --lint 2>&1 | grep 'score set for non-existent' | grep -Po '\S+$'`; do grep -R "score $i " /var/lib/spamassassin/3.003001/; done
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_7429530a7398f43f1f1b795f9420714e 3.999 1.655 2.776 1.479
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_91eb43f705d25c804374a746d7519660 3.099 2.803 2.746 1.572
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_04e8bf28eb445199a7f11b943c44d209 1.712 3.185 2.654 1.337
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score DKIMDOMAIN_IN_DWL_UNKNOWN  0 -0.01 0 -0.01
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_d0d2b0f6373bf91253d66dd74c594b87 3.799 2.040 2.710 1.494
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score ADVANCE_FEE_3 2.686 1.898 3.505 3.817
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_3b92eda751c992f230f215fb7eb36844 0.001 0.626 0.585 3.040
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_4ef8302546bf270a19baf98508afacc4 2.231 3.464 2.266 3.543
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_2b173a7fb7518c75ac8a2d294d773fd8 2.976 1.117 1.951 0.942
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SHORTCIRCUIT 0 # n=0 n=1 n=2
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SUBJ_RE_NUM 0 # n=0 n=1 n=2 n=3
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score FM_VIAGRA_SPAM1114 0 # n=0 n=1 n=2 n=3
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score SANE_1c4f3286fa4aed6424ced88bfaf8b09c 3.199 2.040 3.199 1.502
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score ADVANCE_FEE_2 2.314 2.294 1.198 1.053
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score AXB_HELO_LH_HOME 3.406 2.059 3.458 3.619
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score DKIMDOMAIN_IN_DWL 0 -3.5 0 -3.5
/var/lib/spamassassin/3.003001/updates_spamassassin_org/73_sandbox_manual_scores.cf:score HK_FAKENAME_MICROSOFT    2.50
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score ACCESSDB 0 # n=0 n=1 n=2
/var/lib/spamassassin/3.003001/updates_spamassassin_org/50_scores.cf:score ADVANCE_FEE_4 0.001 0.001 0.001 0.271

I'm going to correct these by either removing the offending entries; or by wrapping them in the correct ifplugin (e.g. ACCESSDB, SHORTCIRCUIT and DKIMDOMAIN_* rules).

Comment 1 Steve Freegard 2011-02-16 05:33:54 UTC

(In reply to comment #0)
> On a fresh installation I'm seeing 19 of these after running an sa-update:
> 
> I'm going to correct these by either removing the offending entries; or by
> wrapping them in the correct ifplugin (e.g. ACCESSDB, SHORTCIRCUIT and
> DKIMDOMAIN_* rules).

Ok - I should have checked first but trunk is correct; these rules are not present in 50_scores.cf and the others are correctly wrapped within the right ifplugin.

So it looks like the sa-updates are borked - anyone have any ideas??

Comment 2 AXB 2011-02-16 05:37:08 UTC

removed from 10_force_active.cf (rulesrc)

publish SANE_04e8bf28eb445199a7f11b943c44d209
publish SANE_1c4f3286fa4aed6424ced88bfaf8b09c
publish SANE_2b173a7fb7518c75ac8a2d294d773fd8
publish SANE_3b92eda751c992f230f215fb7eb36844
publish SANE_4ef8302546bf270a19baf98508afacc4
publish SANE_7429530a7398f43f1f1b795f9420714e
publish SANE_91eb43f705d25c804374a746d7519660
publish SANE_d0d2b0f6373bf91253d66dd74c594b87

Comment 3 AXB 2011-02-16 05:37:52 UTC

(In reply to comment #2)
> removed from 10_force_active.cf (rulesrc)
> 
> publish SANE_04e8bf28eb445199a7f11b943c44d209
> publish SANE_1c4f3286fa4aed6424ced88bfaf8b09c
> publish SANE_2b173a7fb7518c75ac8a2d294d773fd8
> publish SANE_3b92eda751c992f230f215fb7eb36844
> publish SANE_4ef8302546bf270a19baf98508afacc4
> publish SANE_7429530a7398f43f1f1b795f9420714e
> publish SANE_91eb43f705d25c804374a746d7519660
> publish SANE_d0d2b0f6373bf91253d66dd74c594b87

revision: 1071196

Comment 4 AXB 2011-02-16 05:45:11 UTC

in 50_scores_cf

#score ADVANCE_FEE_2 2.314 2.294 1.198 1.053
#score ADVANCE_FEE_3 2.686 1.898 3.505 3.817
#score ADVANCE_FEE_4 0.001 0.001 0.001 0.271


yet

10_force_active.cf

publish ADVANCE_FEE_2
publish ADVANCE_FEE_3
publish ADVANCE_FEE_4

Comment 5 John Hardin 2011-02-16 11:16:06 UTC

(In reply to comment #4)
> in 50_scores_cf
> 
> #score ADVANCE_FEE_2 2.314 2.294 1.198 1.053
> #score ADVANCE_FEE_3 2.686 1.898 3.505 3.817
> #score ADVANCE_FEE_4 0.001 0.001 0.001 0.271
> 
> 
> yet
> 
> 10_force_active.cf
> 
> publish ADVANCE_FEE_2
> publish ADVANCE_FEE_3
> publish ADVANCE_FEE_4

Mea Culpa, I didn't check 10_force_active.cf when disabling the older ADVANCE_FEE_# rules.

You are welcome to fix it or I will do so shortly.

Comment 6 AXB 2011-02-16 11:20:47 UTC

(In reply to comment #5)
> (In reply to comment #4)
> > in 50_scores_cf
> > 
> > #score ADVANCE_FEE_2 2.314 2.294 1.198 1.053
> > #score ADVANCE_FEE_3 2.686 1.898 3.505 3.817
> > #score ADVANCE_FEE_4 0.001 0.001 0.001 0.271
> > 
> > 
> > yet
> > 
> > 10_force_active.cf
> > 
> > publish ADVANCE_FEE_2
> > publish ADVANCE_FEE_3
> > publish ADVANCE_FEE_4
> 
> Mea Culpa, I didn't check 10_force_active.cf when disabling the older
> ADVANCE_FEE_# rules.
> 
> You are welcome to fix it or I will do so shortly.

Removed.

Comment 7 Kevin A. McGrail 2011-11-01 22:52:21 UTC

After the most recent update, still seeing a few of these.  Alex and Theo, can you take a look just to try and clean these up?  Very low priority IMO but might point to a broken rule...

Nov  1 18:46:32.538 [22759] dbg: config: warning: score set for non-existent rule AXB_XMID_1212
Nov  1 18:46:32.538 [22759] dbg: config: warning: score set for non-existent rule AXB_XM_SENDMAIL_NOT
Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent rule TVD_PH_SUBJ_URGENT
Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent rule TVD_PH_SUBJ_ACCOUNTS_POST
Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent rule AXB_XMID_1510
Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent rule TVD_PH_SUBJ_SEC_MEASURES
Nov  1 18:46:32.540 [22759] dbg: config: warning: score set for non-existent rule AXB_XR_STULDAP
Nov  1 18:46:32.540 [22759] dbg: config: warning: score set for non-existent rule AXB_XMID_OEGOESNULL

Comment 8 AXB 2011-11-01 22:58:52 UTC

(In reply to comment #7)
> After the most recent update, still seeing a few of these.  Alex and Theo, can
> you take a look just to try and clean these up?  Very low priority IMO but
> might point to a broken rule...
> 

> Nov  1 18:46:32.538 [22759] dbg: config: warning: score set for non-existent
> rule AXB_XMID_1212
> Nov  1 18:46:32.538 [22759] dbg: config: warning: score set for non-existent
> rule AXB_XM_SENDMAIL_NOT
> Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent
> rule AXB_XMID_1510
> rule AXB_XR_STULDAP
> Nov  1 18:46:32.540 [22759] dbg: config: warning: score set for non-existent
> rule AXB_XMID_OEGOESNULL

these rules have been deprecated ages ago but for some reason scores are orphaned.
Will remove asap

Comment 9 AXB 2011-11-01 23:06:37 UTC

(In reply to comment #7)
> After the most recent update, still seeing a few of these.  Alex and Theo, can
> you take a look just to try and clean these up?  Very low priority IMO but
> might point to a broken rule...
> 

> rule TVD_PH_SUBJ_URGENT
> Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent
> rule TVD_PH_SUBJ_ACCOUNTS_POST
> Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent
> rule TVD_PH_SUBJ_SEC_MEASURES

this seems to be stuff from pre autopromotion days

seems KAM modified Theo's /sandbox/felicity/70_phishing.cf 

"# 2011-07-01 Changed by KAM - https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6579"
#Changed to Sub Rules"

but TVD_PH_SUBJ_META1 meta rule is not using the __* rules above it

KAM: pls check

Comment 10 Kevin A. McGrail 2011-11-01 23:27:51 UTC

(In reply to comment #9)
> (In reply to comment #7)
> > After the most recent update, still seeing a few of these.  Alex and Theo, can
> > you take a look just to try and clean these up?  Very low priority IMO but
> > might point to a broken rule...
> > 
> 
> > rule TVD_PH_SUBJ_URGENT
> > Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent
> > rule TVD_PH_SUBJ_ACCOUNTS_POST
> > Nov  1 18:46:32.539 [22759] dbg: config: warning: score set for non-existent
> > rule TVD_PH_SUBJ_SEC_MEASURES
> 
> this seems to be stuff from pre autopromotion days
> 
> seems KAM modified Theo's /sandbox/felicity/70_phishing.cf 
> 
> "# 2011-07-01 Changed by KAM -
> https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6579"
> #Changed to Sub Rules"
> 
> but TVD_PH_SUBJ_META1 meta rule is not using the __* rules above it
> 
> KAM: pls check


I thought I fixed that in July when you emailed me about it.  Appears I never committed :-(

svn commit -m 'fixing __s missing on meta rule  bug 6543'
Sending        rulesrc/sandbox/felicity/70_phishing.cf
Transmitting file data .
Committed revision 1196393.

Closing as resolved.