Bug 6477 - sa-update contains path of build-environment
Summary: sa-update contains path of build-environment
Status: RESOLVED WORKSFORME
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Building & Packaging (show other bugs)
Version: 3.3.2
Hardware: PC Linux
: P2 normal
Target Milestone: 3.3.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-08 15:07 UTC by sca
Modified: 2011-11-01 20:01 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
patch to make sa-update contain correct path patch None sca@andreasschulze.de [NoCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description sca 2010-08-08 15:07:38 UTC 
after packaging SA for debian
sa-update contains the path of the build-environment

the patch fixes that ( for me )
Comment 1 sca 2010-08-08 15:24:51 UTC 
Created attachment 4798 [details]
patch to make sa-update contain correct path
Comment 2 Mark Martinec 2011-05-18 12:45:43 UTC 
> Created attachment 4798 [details]
> patch to make sa-update contain correct path

Not sure I understand the issue.
The patch drops a dependency of sa-update on build_rules:

- sa-update: sa-update.raw build_rules
+ sa-update: sa-update.raw

which is probably fine, but as far as I can see
it makes no difference on the produced and installed sa-update.

So what is the actual problem being solved here?
Comment 3 sca 2011-05-31 21:56:09 UTC 
I just retried building 3.3.2.rc2 with and without the patch.

without, depending on build_rules,
  sa-update contains paths only used by my buildsytem
with patch, not depending on build_rules, sa-update looks normal.

looking info Makefile.pl, sa-update is the only target depending on build_rules...

Andras
Comment 4 Kevin A. McGrail 2011-05-31 22:09:22 UTC 
(In reply to comment #3)
> I just retried building 3.3.2.rc2 with and without the patch.
> 
> without, depending on build_rules,
>   sa-update contains paths only used by my buildsytem
> with patch, not depending on build_rules, sa-update looks normal.
> 
> looking info Makefile.pl, sa-update is the only target depending on
> build_rules...
> 
> Andras

OK, so I too 3.3.1, ran make.

took the resulting sa-update and named it sa-update.prev

then ran make clean and edited the Makefile.PL to remove build_rules and ran make again.

comparing the sa-updates that result, they are identical.

Repeating with 3.3.2-rc2, i have the exact same result. 

In short, sa-update isn't changed.

According to a TODO in the Makefile.PL, build_rules is called on purpose with sa-update.

Can you run diffs on the sa-update to show us what is changing?
Comment 5 Kevin A. McGrail 2011-11-01 20:01:01 UTC 
Closing based on the inability to replicate.