Bug 6463 - Warnings with Perl 5.12.1 and deprecated constructs.
Summary: Warnings with Perl 5.12.1 and deprecated constructs.
Status: RESOLVED DUPLICATE of bug 6392
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: 3.3.1
Hardware: PC Linux
: P5 minor
Target Milestone: 3.3.2
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-17 02:21 UTC by D. Stussy
Modified: 2010-07-18 07:18 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description D. Stussy 2010-07-17 02:21:37 UTC 
Use of "goto" to jump into a construct is deprecated at /usr/local/lib/perl5/site_perl/5.12.1/Mail/SpamAssassin/Plugin/Check.pm line 409.

defined(%hash) is deprecated at /usr/local/lib/perl5/site_perl/5.12.1/Mail/SpamAssassin/Dns.pm line 757.
	(Maybe you should just omit the defined()?)


Everything works, but each time the perl interpreter hits one of the deprecated constructs, I get a syslog entry, and there's alot of them.  The DNS one seems to generate one log entry for every DNS query encountered, and between SPF, DomainKeys, and DNSBLs, there are alot of queries per message.

No such messages appeared with Perl 5.12.0 or earlier.  Perl has changed, but SA hasn't kept up.  If this isn't fixed soon, SA could break as Perl is enhanced.
Comment 1 Mark Martinec 2010-07-17 05:51:59 UTC 
Already fixed in 3.3(.2) SVN and in 3.4 (trunk). Duplicate of bug 6392.

*** This bug has been marked as a duplicate of bug 6392 ***
Comment 2 D. Stussy 2010-07-17 18:04:36 UTC 
OK.  Sorry.  I didn't find that bug when I searched for the problem before reporting it because it didn't reference the version of Perl that it first appeared with (which was 5.12.1, not 5.12.0 nor "5.12") on my system.

Could we push version 3.3.2 out before the end of the month?  Thanks.
Comment 3 Mark Martinec 2010-07-18 07:18:00 UTC 
> Could we push version 3.3.2 out before the end of the month?  Thanks.

I doubt it would be possible in July, people are on vacation right now
or in the near future, and there wasn't much activity even in June.
Perhaps more likely in August, depending on how we regain momentum.

Just use the SVN version if you need any new fixes (3.3),
or the 3.4 (trunk) if you need fixes AND new features.
Both should be pretty stable and working well in production
at some sites.