and as suggested, please remove these from default whitelist (facebook and linkedin. ) there is more legit spam from them than forged spam.

trunk:
Bug 6382: add in missing unwhitelist_from_dkim
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Committed revision 925353.

Bug 6382: removed facebook and linkedin from def_whitelist_from_dkim
Sending rules/60_whitelist_dkim.cf
Committed revision 925354.

(In reply to comment #3)
> Bug 6382: removed facebook and linkedin from def_whitelist_from_dkim
> Sending rules/60_whitelist_dkim.cf
> Committed revision 925354.

I can't test the code but I'm +1 on 3.3.2 after reviewing the patch.  

Do we have and statistics on facebook and linkedin spam, though?  I've not seen much linkedin spam.

> Bug 6382: add in missing unwhitelist_from_dkim

I intend to enhance the change a bit further to allow more
selective removal of entries based on signing domain too,
so I'm removing the [review] status temporarily. The patch
is alright as it is now for those who need the functionality
right away.

please add youtube to the domains to remove from default opt out.

their email program and process leave no ability to opt-out of the emails.

if you can't opt-out of spam you never requested, you should not have to fight with whitelisting in SA defaults.

(In reply to comment #4)
> (In reply to comment #3)
> > Bug 6382: removed facebook and linkedin from def_whitelist_from_dkim
> > Sending rules/60_whitelist_dkim.cf
> > Committed revision 925354.
> 
> I can't test the code but I'm +1 on 3.3.2 after reviewing the patch.  
> 
> Do we have and statistics on facebook and linkedin spam, though?  I've not seen
> much linkedin spam.

as a fyi, facebook gets listed in spamcop all the time.(cisco ironport users?)

(sorry about the wrapping)
<http://www.senderbase.org/senderbase_queries/detailip?search_string=69.63.176.0%2F20>

Bug 6382#6: removing service@youtube.com and amazon from def_whitelist_from_dkim
Sending rules/60_whitelist_dkim.cf
Committed revision 943958.

(In reply to comment #8)
> Bug 6382#6: removing service@youtube.com and amazon from
> def_whitelist_from_dkim
> Sending rules/60_whitelist_dkim.cf
> Committed revision 943958.

and, just as a clarification, since I am running 3.3.1.. 
these rule changes are ONLY on 3.3.2, and have not been backported to 3.3.1?
(since I still see linkedin in my 60_whitelist_dkim.cf on 3.3.1)

right? no backporting of these rule changes?

(In reply to comment #5)
> I intend to enhance the change a bit further to allow more
> selective removal of entries based on signing domain too,
> so I'm removing the [review] status temporarily. The patch
> is alright as it is now for those who need the functionality
> right away.

Ok, here is now the final version of the change.

With the first version of this patch the unwhitelist_from_dkim command used
only one parameter (email address), just like unwhitelist_from_rcvd, and
removed all addresses regardless of a signing domain (the second parameter
in whitelist_from_dkim).

Now the unwhitelist_from_dkim command has two parameters, exactly like
the whitelist_from_dkim, and both must match for a corresponding entry
to be removed. This allows for selectively removing just some but not all
entries for a given email address.


trunk:
  Bug 6382 - add missing unwhitelist_from_dkim, part deux
Sending lib/Mail/SpamAssassin/Conf/Parser.pm
Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
Committed revision 949831.

Created attachment 4763 [details]
A combined patch

For ease of inspection: this is now a merged final patch, implementing
the unwhitelist_from_dkim configuration option as documented.

Returning to a review status.

(In reply to comment #9)
> > Bug 6382#6: removing service@youtube.com and amazon from
> and, just as a clarification, since I am running 3.3.1.. 
> these rule changes are ONLY on 3.3.2, and have not been backported to 3.3.1?
> (since I still see linkedin in my 60_whitelist_dkim.cf on 3.3.1)
> 
> right? no backporting of these rule changes?

No, there is only one set of rules now, the change should be visible
after a sa-update under 3.3.1 as well. There may have been a delay of
a couple of days due to sa-update propagation conditions and some problems
with it. There should no longer be a 'def_whitelist_from_dkim *@linkedin.com'
in 60_whitelist_dkim.cf, along with few other removed entries mentioned
in this PR.

Clarifying that I am voting for the patch. 1 more vote needed for 3.3.2.

Just a fyi.  Linkedin slammed a service account. Protected by whitelsting.  No remove options.
Returnpath certified it. And defended the lack of any remove address

+1 looks ok

3.3:
  Bug 6382: add missing unwhitelist_from_dkim,
  remove facebook and linkedin from dkim whitelisting
  Sending lib/Mail/SpamAssassin/Conf/Parser.pm
  Sending lib/Mail/SpamAssassin/Plugin/DKIM.pm
  Sending rules/60_whitelist_dkim.cf
Committed revision 1101026.