Bug 6198 - SOUGHT Rules invalid regexp
Summary: SOUGHT Rules invalid regexp
Status: RESOLVED WONTFIX
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Rules (show other bugs)
Version: 3.2.5
Hardware: All Linux
: P5 normal
Target Milestone: 3.2.6
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-12 18:52 UTC by Alex
Modified: 2011-06-03 14:58 UTC (History)
3 users (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2009-09-12 18:52:23 UTC
Hi all,

I'm using sa-3.2.5 on Linux with perl-5.6 and seem to be having a problem with the sought fraud rules and "Can't use \x{} without 'use utf8' declaration".

Am I doing something wrong or is this a bug?

[13204] dbg: config: read file /var/lib/spamassassin/3.002005/sought_rules_yerp_
org/20_sought.cf
[13204] warn: config: invalid regexp for rule __SEEK_D52BRW: / Don\'t want to lo
se your potential of a lover\? Lucky you are, in 21th century all bed-related ma
le problems can be solved by the powerful remedy, the all-mighty blue caplet\! T
his solution will give you the right support for 50\(\!\) hours\. Rock-like and
ready to go\. more\x{bb}/: / Don\'t want to lose your potential of a lover\? Luc
ky you are, in 21th century all bed-related male problems can be solved by /: Ca
n't use \x{} without 'use utf8' declaration

Please let me know how I can go about troubleshooting this or if there is further information I can provide.

Thanks,
Alex
Comment 1 Mark Martinec 2009-09-27 17:03:35 UTC
> I'm using sa-3.2.5 on Linux with perl-5.6 and seem to be having a problem with
> the sought fraud rules and "Can't use \x{} without 'use utf8' declaration".
> 
> Am I doing something wrong or is this a bug?

It's been fixed with perl 5.8.0 (maybe even with 5.6.1).

> Please let me know how I can go about troubleshooting this or if there is
> further information I can provide.

Either change the rule causing the problem to avoid \x{}, or upgrade your
perl, or change SpamAssassin to add 'use utf8' into code generated from rules
when it sees it is being run with a pre-5.8 version of perl.

The 5.8 series has been around for more than 7 years now, the current stable
version is 5.10.1.
Comment 2 Karsten Bräckelmann 2009-09-28 06:31:34 UTC
Tempted to close this bug report, cause the SOUGHT rule-set is third-party and not SA. Keeping open for now, since 3.2 still officially supports Perl 5.6.
Comment 3 Mark Martinec 2009-10-15 09:26:53 UTC
From my posting to the SA mailing list:

On Monday September 28 2009 04:58:42 MySQL Student wrote:
> Mark suggested in the bugzilla update that I "change SpamAssassin to
> add 'use utf8' into code generated from rules when it sees it is being
> run with a pre-5.8 version of perl." How do I do this for the time
> being?

Try the following (for SA 3.2.5). I haven't tested it, but according
to the perl docs this is what is missing:


--- lib/Mail/SpamAssassin/Plugin/Check.pm	(revision 819489)
+++ lib/Mail/SpamAssassin/Plugin/Check.pm	(working copy)
@@ -271,10 +271,14 @@
 
   my $evalstr = $self->{evalstr};
 
+  my $needed_utf8_pragma = '';
+  $needed_utf8_pragma = 'use utf8;'  if $] >= 5.006 && $] < 5.008;
+
   # generate the loop that goes through each line...
   $evalstr = <<"EOT";
   {
     package $package_name;
+    $needed_utf8_pragma;
 
     $self->{evalstr2}
Comment 4 Darxus 2011-05-31 22:08:24 UTC
Close.

Problem is fixed in version of perl required by 3.3.

(In reply to comment #2)
> Tempted to close this bug report, cause the SOUGHT rule-set is third-party and
> not SA. Keeping open for now, since 3.2 still officially supports Perl 5.6.

"Perl 5.8.1 or a later version is required." - 3.3.2rc2 INSTALL
Comment 5 Kevin A. McGrail 2011-05-31 22:11:44 UTC
(In reply to comment #4)
> Close.
> 
> Problem is fixed in version of perl required by 3.3.

Roger.  Will bring up getting an official release policy that says we aren't supporting 3.2 anymore.
Comment 6 D. Stussy 2011-05-31 22:22:04 UTC
NOe:  If 3.2 (and earlier) is no longer supported, there are many open bug reports that should be closed as "wontfix."  Listing all 696 open bugs shows several of them: e.g. 5719, 5885, 5949, 6015, ... and that's just going by version numbers cited in the bug report titles.
Comment 7 Kevin A. McGrail 2011-05-31 22:28:25 UTC
(In reply to comment #6)
> NOe:  If 3.2 (and earlier) is no longer supported, there are many open bug
> reports that should be closed as "wontfix."  Listing all 696 open bugs shows
> several of them: e.g. 5719, 5885, 5949, 6015, ... and that's just going by
> version numbers cited in the bug report titles.

Yes and no.  I have a feeling some of those bugs will be retargeted but if they are resolved in 3.3.X, I agree completely.

It will be 100% up to the PMC but I've proposed the following schedules for Release and Support.  I am purposefully keeping them short & simple.  I feel the project will benefit from scheduled releases and this schedule is realistic and allows for volunteers to avoid major holidays and summertime.

Release Schedule:

The Apache SpamAssassin project goal is to produce three major or minor releases per year with release candidates proposed on or close to January 30th, April 30th & September 30th of each year.

Release Support:

A major release is supported for no less than 6 months after the release of the next major release.  This means that as of July 27, 2010, all versions prior to 3.3.0 are considered unsupported.  If and when 3.4.0 is released, version prior will then be consider unsupported approximately 6 months later.
Comment 8 Mark Martinec 2011-06-03 14:58:04 UTC
Closing this as 'wontfix', the issue is resolved in perl 5.8.0 or later.