Bug 2165 - folding tests removes commas
Summary: folding tests removes commas
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 normal
Target Milestone: 2.60
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-30 13:45 UTC by Theo Van Dinter
Modified: 2003-07-05 09:40 UTC (History)
0 users



Attachment Type Modified Status Actions Submitter/CLA Status
simple, yet untested patch against PerMsgStatus.pm patch None Malte S. Stretz [HasCLA]
revised patch patch None Malte S. Stretz [HasCLA]

Note You need to log in before you can comment on or make changes to this bug.
Description Theo Van Dinter 2003-06-30 13:45:11 UTC
X-Spam-Status: Yes, hits=34.6 required=5.0 tests=BAYES_99,BULK_EMAIL,CLICK_BELOW
        DATE_IN_FUTURE_06_12,DCC_CHECK,DNS_FROM_RFCI_DSN,EMAIL_MARKETING

notice there's no comma between CLICK_BELOW and DATE_IN_FUTURE_06_12
Comment 1 Malte S. Stretz 2003-06-30 15:31:29 UTC
Created attachment 1114 [details]
simple, yet untested patch against PerMsgStatus.pm

Seems like somebody "simplified" the Text::Wrap call since 2.55 ;-) The
attached patch should do the trick even though I don't know if it clashes with
$Text::Wrap::huge which also changed from 'overflow' to 'wrap'...

P.S.: Whew, seems like I found a second to really change a line of code in SA
again ;-)
Comment 2 Malte S. Stretz 2003-06-30 15:34:55 UTC
Created attachment 1115 [details]
revised patch

doh! I really need a DWIM-enabled editor...
Comment 3 Justin Mason 2003-06-30 17:24:31 UTC
yeah, I'm kind of confused about why that format changed, too.
+1 for that fix.  will it work on perl 5.005?
Comment 4 Theo Van Dinter 2003-07-05 08:40:28 UTC
this is actually a bug in 2.60 ...
Comment 5 Theo Van Dinter 2003-07-05 17:01:58 UTC
+1 if it works on 5.005

if I get a chance, I'll go to my vmware box tonight, which has 5.005 and see 
what it does with things.
Comment 6 Theo Van Dinter 2003-07-05 17:38:43 UTC
ok, I just tested on my 5.005 vmware install, and it worked ok.  the only failed test was the 
spamd_protocol_10 test, which fails on my 5.005 install without the patch (can't find "seek" as an 
export tag via Fcntl ...)

so I'd say +1 to this patch. :)
Comment 7 Theo Van Dinter 2003-07-05 17:40:08 UTC
committed.