Bug 1966 - MakeMaker 6.05 and the RPM spec file
Summary: MakeMaker 6.05 and the RPM spec file
Status: RESOLVED DUPLICATE of bug 2388
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Packaging: RPM (show other bugs)
Version: 2.55
Hardware: Other other
: P5 normal
Target Milestone: 2.70
Assignee: Theo Van Dinter
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-25 16:39 UTC by Wayne Davison
Modified: 2003-09-12 10:15 UTC (History)
1 user (show)



Attachment Type Modified Status Actions Submitter/CLA Status

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Davison 2003-05-25 16:39:45 UTC
I was looking at the spamassin.spec file the other day in order to transfer
that build sequence over to the Gentoo Linux ebuild (to fix a couple bugs),
and I noticed that the build sequence specified in the spec file was not
working right.  I tracked down the root cause to the value of the SITEPREFIX
var that MakeMaker 6.05 is putting into the Makefile:

In earlier versions (such as 5.45) MakeMaker put the literal value $(PREFIX)
into this variable (unexpanded).  In MakeMaker 6.05, SITEPREFIX has the
expanded value of the PREFIX=$RPM_BUILD_ROOT/%{_prefix} setting stored
literally, so the "override" in the next command no longer has any function,
and the scripts get the wrong perl-lib dir in them.

I fixed the problem by forcing the value of SITEPREFIX to $(PREFIX) in
the "perl Makefile.PL" step.  I haven't tried this for building an RPM,
but it works great for my ebuild, so I figure a change like this is needed
in the spec file (I inserted the "SITEPREFIX=..." bit into this line):

  %{__perl} Makefile.PL INST_PREFIX=%{_prefix} SITEPREFIX=\$(PREFIX)
INST_SYSCONFDIR=%{_sysconfdir} PREFIX=$RPM_BUILD_ROOT/%{_prefix}
SYSCONFDIR=$RPM_BUILD_ROOT/%{_sysconfdir} < /dev/null

While you're at it, if the </dev/null bit is supposed to keep the the build
from prompting the user about the RAZOR checks, I'd suggest changing this to
add the "RUN_RAZOR1_TESTS=n RUN_RAZOR2_TESTS=n" settings instead.
Comment 1 Daniel Quinlan 2003-09-12 16:52:28 UTC
reassigning to Theo
Comment 2 Theo Van Dinter 2003-09-12 18:15:32 UTC

*** This bug has been marked as a duplicate of 2388 ***