html:image takes a "module-aware" path but does not allow module to be specified

• Key: STR-2967
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Niall Pemberton
• Reporter: Michael Coram
• Component/s: Tag Libraries
• Affects Version/s: 1.3.5
• Fix Version/s: 1.3.6

Description

I am using Struts modules, but I have images that span modules placed at the root of my web application. I am attempting to use the <html:image> tag to render a <input type="image"> entry. Unfortunately, while the Taglib docs says that page is "The module-relative path of the image for this input tag" the tag does not actually accept the module attribute. So, you've either got to use src and specify the entire path or use a relative path. Or, you can just fix the tag... :)

I've actually done the latter, basing the code off of what <html:img> does. I was hoping to be able to attach it here, but not sure how...

Comments

[Michael Coram]

my diffs are marked with //being module fix and //end module fix. Also, struts-html.tld needs to be updated to add the module attribute into it:
<attribute>
<name>module</name>
<required>false</required>
<rtexprvalue>true</rtexprvalue>
</attribute>

[Niall Pemberton]

Fixed in revision #470163, thanks for the patch!

I added the new module attribute to the nested and el taglibs - as well as the vanilla flavour.

http://svn.apache.org/viewvc?view=rev&revision=470163