[#STR-2889] Updated Checkstyle rules

Struts 1

Updated Checkstyle rules

Created: 20/Jun/06 12:19 PM Updated: 04/Jul/07 03:25 AM

Return to search

Component/s:

Core, Example Applications, Extras, JSF Integration (Dormant), Scripting, Tag Libraries, Tag Libraries EL (Dormant), Tiles 1 Plugin

Affects Version/s:

1.2 Family, 1.3 Family

Fix Version/s:

1.3.5

File Attachments:

	File Name	Date Attached	Attached By	Size
	checkstyle_rules.patch	2006-06-20 12:20 PM	Frank W. Zammetti	3 kB

Environment:

Any

Flags:

Patch

Description

« Hide

Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...

With reference to this thread on the @dev list:

http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/%3c448F56CF.2060207@omnytex.com%3e

Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.

All

Comments

Change History

Subversion Commits

Sort Order:

Frank W. Zammetti made changes - 20/Jun/06 12:20 PM

Field	Original Value	New Value
Attachment		checkstyle_rules.patch [ 13071 ]

Ted Husted made changes - 07/Jul/06 05:12 PM

Fix Version/s

1.3.5 [ 21721 ]

Wendy Smoak made changes - 12/Jul/06 12:45 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
Assignee		James Mitchell [ jmitchell ]

Paul Benedict made changes - 04/Jul/07 03:25 AM

Status

Resolved [ 5 ]

Closed [ 6 ]