Updated Checkstyle rules

• Key: STR-2889
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: James Mitchell
• Reporter: Frank W. Zammetti
• Component/s: Core, Example Applications, Extras, JSF Integration (Dormant), Scripting, Tag Libraries, Tag Libraries EL (Dormant), Tiles 1 Plugin
• Affects Version/s: 1.2 Family, 1.3 Family
• Fix Version/s: 1.3.5

Description

Argh, I have the priority choices... shouldn't there be something in between minor and major?!? But I digress...

With reference to this thread on the @dev list:

http://mail-archives.apache.org/mod_mbox/struts-dev/200606.mbox/[e-mail]%3e

Attached is a patch for the Checkstyle rules that eliminates the two things discussed in this thread. It resolves a few hundred exceptions in core alone (350-400, give or take), and should do the same for all other subprojects. There seemed to be a feeling (don't want to say consensus at this point!) that applying this before the next milestone would be acceptable.

Comments

[Frank W. Zammetti]

Patch for Checkstylr rules file

[Frank W. Zammetti]

Hehe, late-night typo... That's supposed to be "...I HATE the priority choices..."

[James Mitchell]

Frank, thanks for the patch. By the way, can you turn off 'remove line endings' from your editor? As you probably noticed, it just adds noise to the signal. Nonetheless, thanks again.

--
James Mitchell

[James Mitchell]

Patch applied, however I want to leave this open while more tweaks (if any) are made.

Thanks again.

[Wendy Smoak]

I deployed a snapshot of struts-build.jar, including Frank's changes.

 * http://people.apache.org/maven-snapshot-repository/org/apache/struts/struts-build/

To see the new rules in effect, change the struts-build <extension> version in the struts-action-parent (or other) pom from v1.0.1 to v1.0.2-SNAPSHOT.

(To try out other rule changes locally, modify maven/build/struts_checks.xml, then 'mvn install' from there.

The maven/build directory needs to be organized into src/main/resources, eventually.)

[Wendy Smoak]

http://svn.apache.org/viewvc?rev=415519&view=rev