If a field's display property is set to 'none' using CSS or JavaScript, the focus code fails.

• Key: STR-2826
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Don Brown
• Reporter: Zarar Siddiqi
• Component/s: Tag Libraries
• Affects Version/s: 1.2.9
• Fix Version/s: 1.3.3

Environment

Operating System: other
Platform: Other

Description

If a field's display property is set to 'none' using CSS or JavaScript, the
current code still tries to give the field focus which will result in an error
in IE.

A patch is for the org.apache.struts.taglib.html.FormTag.java file and is attached:

663c663
< " if (focusControl.type != \"hidden\" && !focusControl.disabled) {");
---
> " if (focusControl.type != \"hidden\" && !focusControl.disabled
&& focusControl.style.display != \"none\") {");

Comments

[Zarar Siddiqi]

Created an attachment (id=18044)
Patch to apply to org.apache.struts.taglib.html.FormTag to fix focus() bug.

[Don Brown]

The patch has been applied against trunk, so give it a shot and close the ticket if you found it fixed. Thanks for the patch!

[Zarar Siddiqi]

This worked for me. Thanks. Can't find the option to 'close' this issue so I'll leave that to you...

[Don Brown]

Ok, try again, the permissions should be fixed.

[Zarar Siddiqi]

This is now fixed.