ImportAttribute does not import all attribute with ignore=true

• Key: STR-2809
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Don Brown
• Reporter: Andrzej Turowski
• Component/s: Tiles 1 Plugin
• Affects Version/s: 1.2.8
• Fix Version/s: 1.3.3

Environment

Operating System: other
Platform: Other

Description

If we have a list of attribute and a null value is encountered SKIP_BODY is
returned and other attributes are not imported into the pageContext.
I think we need to take out the else clause?

public int doStartTag() throws JspException
 ....
 ....


if( value == null ) {
          if(!isErrorIgnored)
            throw new JspException ( "Error - tag importAttribute : property '"+
name + "' has a value of 'null'" );
          else
            return SKIP_BODY;
        }

should become

if( value == null ) {
          if(!isErrorIgnored)
            throw new JspException ( "Error - tag importAttribute : property '"+
name + "' has a value of 'null'" );

        }

Comments

[Don Brown]

Makes sense to me. Please close if this fixes your problem.