[#STR-2809] ImportAttribute does not import all attribute with ignore=true

Struts 1

ImportAttribute does not import all attribute with ignore=true

Created: 23/Mar/06 04:49 PM Updated: 03/Jul/07 08:36 PM

Component/s:

Tiles 1 Plugin

Affects Version/s:

1.2.8

Fix Version/s:

1.3.3

Environment:

« Hide

Operating System: other
Platform: Other

Bugzilla Id:

http://issues.apache.org/bugzilla/show_bug.cgi?id=39084

Description

« Hide

If we have a list of attribute and a null value is encountered SKIP_BODY is
returned and other attributes are not imported into the pageContext.
I think we need to take out the else clause?

public int doStartTag() throws JspException
....
....

if( value == null ) {
          if(!isErrorIgnored)
            throw new JspException ( "Error - tag importAttribute : property '"+
name + "' has a value of 'null'" );
          else
            return SKIP_BODY;
        }

should become

if( value == null ) {
          if(!isErrorIgnored)
            throw new JspException ( "Error - tag importAttribute : property '"+
name + "' has a value of 'null'" );

        }

All

Comments

Change History

Subversion Commits

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Don Brown - 07/May/06 06:08 AM

Makes sense to me. Please close if this fixes your problem.