Validator validwhen comparisons of floats

• Key: STR-2319
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Paul Benedict
• Reporter: Nuno Furtado
• Component/s: Core
• Affects Version/s: 1.2.2
• Fix Version/s: 1.4.0

Environment

Operating System: All
Platform: PC

Description

I needed to validate a field if another one was diferent than zero, it should be
expected that i was able to do it like so :
<field property="outros" depends="validwhen">
<arg2 key="compostagemdataForm.outros.invalido"/>
<var>
<var-name>test</var-name>
<var-value>(qtoutros==0)</var-value>
</var>
</field>

For some reason this rule allways failed. i had to reformulate the rule :
<field property="outros" depends="validwhen">
<arg2 key="compostagemdataForm.outros.invalido"/>
<var>
<var-name>test</var-name>
<var-value>(qtoutros=='0.0') </var-value>
</var>
</field>

wich is weird! qtoutros is a String property on the bean, but can be converted
to float.

Comments

[Don Brown]

Reassigning to Struts as commons-validator does not have a validwhen validator.

[Henri Yandell]

Only ints are supported by the grammar at the moment, the '0.0' works because you're doing String comparison. I think that doing 0.0 without the quotes would have worked too, but it would really have been working at the String level and you'd have found bugs like STR-2321 when you got to comparison.