Issue Details (XML | Word | Printable)

Key: STR-1559
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Paul Benedict
Reporter: Dirk Coetsee
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Struts 1

[taglib] Need Bidirectional support for RtoL languages in html:html tag

Created: 30/Jun/03 01:59 AM   Updated: 04/Jul/07 03:36 AM
Return to search
Component/s: Tag Libraries
Affects Version/s: 1.1 RC2, 1.1.1
Fix Version/s: 1.3.6

Environment:
Operating System: All
Platform: All

Bugzilla Id: 21171


 Description  « Hide
The html tag has a DIR parameter that you can set to dir="rtl" . This will have
the effect that the whole page flip from right to left. It is needed for
languages such as Arabic and Hebrew.

The html:html tag should add the Dir="rtl" to the generated html tag when the
local is for a rtl language. arabic = windows1256

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Vic Cekvenich added a comment - 28/Aug/03 10:34 AM
Do you have sample solution code?
.V

Ted Husted added a comment - 19/Dec/03 08:56 AM
Reopening for handling in 1.2.x

Cris Daniluk added a comment - 19/Jan/05 05:27 AM
(In reply to comment #0)
> The html tag has a DIR parameter that you can set to dir="rtl" . This will have
> the effect that the whole page flip from right to left. It is needed for
> languages such as Arabic and Hebrew.
>
> The html:html tag should add the Dir="rtl" to the generated html tag when the
> local is for a rtl language. arabic = windows1256

According to the HTML 4.01 spec, dir is part of the %i18n attribute set, which
is used by virtually every HTML tag. It is not just needed for HTML, but in fact
all tags in the struts-html tld. See google.com in a bidi language for an
example of how this attribute is used to properly control the direction of a page.

Sven Rottenbiller added a comment - 18/Jun/05 01:23 AM
A solution for this bug you can fing in BUG#35396.

Don Brown made changes - 23/Apr/06 04:43 AM
Field Original Value New Value
issue.field.bugzillaimportkey 21171 26850
Paul Benedict made changes - 25/Nov/06 03:05 AM
Assignee Struts Developers [ dev@struts.apache.org ]
Bugzilla Id 21171
Fix Version/s Future [ 21701 ]
Affects Version/s 1.1.1 [ 21691 ]
Fix Version/s 1.3.6 [ 21731 ]
Repository Revision Date User Message
Struts #479243 Sun Nov 26 00:46:58 UTC 2006 pbenedict STR-1559: Added dir and lang attributes to regular+nested taglibs
Files Changed
MODIFY /struts/struts1/trunk/apps/cookbook/src/main/webapp/jsp/localization/Localization.jsp

Repository Revision Date User Message
Struts #479244 Sun Nov 26 00:47:09 UTC 2006 pbenedict STR-1559: Added dir and lang attributes to regular+nested taglibs
Files Changed
MODIFY /struts/struts1/trunk/taglib/src/main/resources/META-INF/tld/struts-nested.tld
MODIFY /struts/struts1/trunk/taglib/src/main/resources/META-INF/tld/struts-html.tld
MODIFY /struts/struts1/trunk/taglib/src/main/java/org/apache/struts/taglib/html/BaseHandlerTag.java

Paul Benedict added a comment - 26/Nov/06 12:48 AM
Cookbook update:
URL: http://svn.apache.org/viewvc?view=rev&rev=479243

Added dir and lang attributes to regular+nested taglibs
URL: http://svn.apache.org/viewvc?view=rev&rev=479244





Paul Benedict added a comment - 26/Nov/06 12:52 AM
Unlike the initial comment's proposal, the enhancement does not magically alter the direction of the text based on the character encoding. The developer should know ahead of time, through some means, when it is appropriate to alter the direction of the text. This add the I18N attributes so individual elements may be modified when necessary.

Paul Benedict made changes - 26/Nov/06 12:52 AM
Assignee Paul Benedict [ paul4christ79 ]
Repository Revision Date User Message
Struts #479633 Mon Nov 27 14:25:35 UTC 2006 pbenedict STR-1559: Added missing dir and lang attributes to FormTag+OptionTag, and cleared the properties on release
Files Changed
MODIFY /struts/struts1/trunk/taglib/src/main/java/org/apache/struts/taglib/html/BaseHandlerTag.java
MODIFY /struts/struts1/trunk/taglib/src/main/java/org/apache/struts/taglib/html/FormTag.java
MODIFY /struts/struts1/trunk/taglib/src/main/java/org/apache/struts/taglib/html/OptionTag.java

Repository Revision Date User Message
Struts #479635 Mon Nov 27 14:27:18 UTC 2006 pbenedict STR-1559: Added dir and lang attributes to EL support library
Files Changed
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELResetTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELCheckboxTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELFormTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELHiddenTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELRadioTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELImageTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELTextTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELButtonTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELImgTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELOptionTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELSubmitTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELPasswordTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELTextareaTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELCancelTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELLinkTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELFileTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELSelectTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELResetTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELCheckboxTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELFormTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELHiddenTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELImageTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELTextTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELRadioTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELButtonTag.java
MODIFY /struts/struts1/trunk/el/src/main/resources/META-INF/tld/struts-html-el.tld
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELOptionTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELImgTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELTextareaTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELCancelTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELLinkTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELSubmitTagBeanInfo.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELFileTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELSelectTag.java
MODIFY /struts/struts1/trunk/el/src/main/java/org/apache/strutsel/taglib/html/ELPasswordTagBeanInfo.java

Paul Benedict added a comment - 27/Nov/06 02:29 PM
Added missing dir and lang attributes to FormTag+OptionTag, and cleared the properties on release
http://svn.apache.org/viewvc?view=rev&rev=479633

Added dir and lang attributes to EL support library
URL: http://svn.apache.org/viewvc?view=rev&rev=479635


Paul Benedict added a comment - 27/Nov/06 02:31 PM
Internationalization attributes are now fully implemented. Struts 1.2.2 put in the @lang attribute on the <html> tag to match the user's locale, and now 1.3.6 can override the language on all form elements.

Paul Benedict made changes - 27/Nov/06 02:31 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Paul Benedict made changes - 02/Dec/06 09:31 PM
Issue Type Improvement [ 4 ] New Feature [ 2 ]
Bugzilla Id 21171
Paul Benedict made changes - 04/Jul/07 03:36 AM
Status Resolved [ 5 ] Closed [ 6 ]