Verify that the destroy callbacks are being called correctly

• Key: SHALE-374
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Craig McClanahan
• Reporter: Craig McClanahan
• Component/s: Tiger, View
• Fix Version/s: 1.0.4

Description

While reviewing the behavior reported in SHALE-371, it became clear that we do not have automated testing to verify that the destroy callbacks on a ViewController (shale-view) or @View bean (shale-tiger) are being correctly called. Need to (at a minimum) manually verify that for all cases, and (better) provide means to test this automatically so we can catch any future regressions.

Comments

[Craig McClanahan]

I just checked in a fix that ensures the destroy() method on request scoped beans gets called within the context of a JSF request (rather than being part of the cleanup that happens afterwards). This fix will be in the 20061228 nightly build, and is good to go for 1.0.4 as well.

[Craig McClanahan]

It turns out that the order in which beans get their destroy() method called is non-deterministic across platforms, and indeed is different on Solaris/X86 than it is on Linux. Reopening to get this adjusted.

[Craig McClanahan]

I have committed a minimal-risk fix for now, making the test cases accept either ordering of destroy events. We can decide in a future version whether or not to guarantee a particular ordering.