[#SHALE-332] NPE if javax.faces.CONFIG_FILES points to nonexistent file

Shale

NPE if javax.faces.CONFIG_FILES points to nonexistent file

Created: 13/Nov/06 04:02 PM Updated: 23/Jan/07 04:40 PM

Return to search

Component/s:

Tiger

Affects Version/s:

1.0.4-SNAPSHOT

Fix Version/s:

1.0.4

File Attachments:

	File Name	Date Attached	Attached By	Size
	npe_prevention.diff	2006-11-13 04:03 PM	Mario Ivankovits	0.8 kB

Description

« Hide

LifecycleListener2 will fail with a NPE if javax.faces.CONFIG_FILES points to a nonexistent file.

Assumed that the JSF implementation should complain about such misconfigurations the attached patch will let shale-tiger silently ignore such entries.

All

Comments

Change History

Subversion Commits

Sort Order:

Mario Ivankovits made changes - 13/Nov/06 04:02 PM

Field	Original Value	New Value
Priority	Major [ 3 ]	Minor [ 4 ]

Mario Ivankovits made changes - 13/Nov/06 04:03 PM

Attachment

npe_prevention.diff [ 13219 ]

[ Permlink | « Hide ]

Craig McClanahan added a comment - 18/Nov/06 03:19 AM

Reclassify as a bug, and assign to me.

Craig McClanahan made changes - 18/Nov/06 03:19 AM

Issue Type	Improvement [ 4 ]	Bug [ 1 ]
Assignee		Craig McClanahan [ craigmcc ]

Repository	Revision	Date	User	Message
ASF	#476426	Sat Nov 18 03:31:22 UTC 2006	craigmcc	If the "javax.faces.CONFIG_FILES" context init parameter specifies missing configuration resources, silently ignore them (on the assumption that the JSF implementation will have already complained) rather than throwing NPE. Fix based on a patch from Mario Ivankovits (thanks Mario!) but expaded to cover the case where a comma separated list of resources is defined also. ~~SHALE-332~~
				Files Changed
				MODIFY /shale/framework/trunk/shale-tiger/src/main/java/org/apache/shale/tiger/view/faces/LifecycleListener2.java

[ Permlink | « Hide ]

Craig McClanahan added a comment - 18/Nov/06 03:32 AM

Fixed in nightly build 20061118. Will be included in 1.0.4 also.

Thanks for the patch!

Craig McClanahan made changes - 18/Nov/06 03:32 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]
Fix Version/s		1.0.4-SNAPSHOT [ 21740 ]

Rahul Akolkar made changes - 23/Jan/07 04:40 PM

Fix Version/s		1.0.4 [ 21790 ]
Fix Version/s	1.0.4-SNAPSHOT [ 21740 ]

Jeff Turner made changes - 09/Aug/07 07:15 AM

Workflow

Struts [ 38920 ]

Struts - editable closed status [ 41684 ]

Antonio Petrelli made changes - 08/Jan/09 08:56 AM

Workflow

Struts - editable closed status [ 41684 ]

Struts - editable closed status (temporary) [ 46027 ]

Antonio Petrelli made changes - 08/Jan/09 09:08 AM

Workflow

Struts - editable closed status (temporary) [ 46027 ]

Struts - editable closed status [ 53051 ]