Issue Details (XML | Word | Printable)

Key: SHALE-299
Type: Task Task
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Craig McClanahan
Reporter: Craig McClanahan
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Shale

Refactor functionality from shale-core into separate modules

Created: 29/Sep/06 06:26 PM   Updated: 23/Jan/07 04:40 PM
Return to search
Component/s: Core
Affects Version/s: None
Fix Version/s: 1.0.4


 Description  « Hide
To improve the ability of users to select which pieces of Shale functionality they wish to use, split the following functional subsets out of shale-core into their own (new) modules:

* shale-application -- Application controller features

* shale-validator -- Integration with Commons Validator

* shale-view -- View controller, exception handling, application callbacks

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #451484 Fri Sep 29 22:41:29 UTC 2006 craigmcc First step at refactoring the functionality of shale-core, pulling out
all of the view controller functionality. As of this change, web
applications wanting to use this feature should make two changes:

* Add a dependency on shale-view-xxx.jar. For Maven2 users, that
  means adding the following dependency:

    <dependency>
      <groupId>org.apache.shale</groupId>
      <artifactId>shale-view</artifactId>
      <version>${version}</version>
    </dependency>

* If you are using the <s:subview> tag in JSP pages, declare a new
  tag library, and switch to the new (vc:) version of the subview tag.
  The new taglib declaration you need is:

    <%@ taglib prefix="vc" uri="http://shale.apache.org/view" %>

  (as with all tag libraries, the prefix is arbitrary, but "vc"
  is the default.)

SHALE-299
Files Changed
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/view
ADD /shale/framework/trunk/shale-view/src/main/java/overview.html (from /shale/framework/trunk/shale-core/src/main/java/overview.html)
ADD /shale/framework/trunk/shale-view/src/main/resources/org/apache/shale/view/resources
MODIFY /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/validator/CommonsValidatorTestCase.java
ADD /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/view)
DEL /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view
MODIFY /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/resources/Bundle.properties
ADD /shale/framework/trunk/shale-view/src/main/resources/org/apache/shale
MODIFY /shale/framework/trunk/shale-apps/shale-mailreader-jpa/pom.xml
MODIFY /shale/framework/trunk/shale-apps/shale-test-core/pom.xml
ADD /shale/framework/trunk/shale-view/src/main/resources/org
ADD /shale/framework/trunk/shale-view/src/test/java/org/apache/shale/view (from /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/view)
ADD /shale/framework/trunk/shale-view/src/main/java/org/apache/shale
ADD /shale/framework/trunk/shale-view/src/main/java
ADD /shale/framework/trunk/shale-view/src/test/resources
ADD /shale/framework/trunk/shale-view/src/test/java/org/apache
ADD /shale/framework/trunk/shale-view/src/main/resources/META-INF
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/SubviewTag.java
ADD /shale/framework/trunk/shale-view
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/ViewViewHandler.java
REPLACE /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/LifecycleListener.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/view/faces/LifecycleListener.java)
ADD /shale/framework/trunk/shale-view/src/test/java
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/component/Subview.java
ADD /shale/framework/trunk/shale-view/src/main/resources/META-INF/NOTICE.txt
MODIFY /shale/framework/trunk/shale-tiger/pom.xml
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/pom.xml
ADD /shale/framework/trunk/shale-view/src/main/resources/META-INF/faces-config.xml
ADD /shale/framework/trunk/shale-view/src/main
MODIFY /shale/framework/trunk/shale-apps/shale-blank/pom.xml
ADD /shale/framework/trunk/shale-view/src/main/java/org
ADD /shale/framework/trunk/shale-view/src/main/resources/META-INF/LICENSE.txt
MODIFY /shale/framework/trunk/shale-core/src/main/resources/META-INF/faces-config.xml
ADD /shale/framework/trunk/shale-view/src/main/resources/META-INF/taglib.tld
ADD /shale/framework/trunk/shale-view/src
ADD /shale/framework/trunk/shale-view/src/test/java/org/apache/shale
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/subview/second.jsp
ADD /shale/framework/trunk/shale-view/src/test/java/org
MODIFY /shale/framework/trunk/shale-core/src/main/resources/META-INF/taglib.tld
ADD /shale/framework/trunk/shale-view/src/main/resources/org/apache/shale/view
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/subview/first.jsp
ADD /shale/framework/trunk/shale-view/src/main/resources/org/apache
MODIFY /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/faces/ShaleConstants.java
ADD /shale/framework/trunk/shale-view/src/main/resources/org/apache/shale/view/resources/Bundle.properties
MODIFY /shale/framework/trunk/shale-clay/pom.xml
ADD /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/SubviewComponent.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/component/Subview.java)
ADD /shale/framework/trunk/shale-view/src/main/resources
ADD /shale/framework/trunk/shale-view/src/main/java/org/apache
ADD /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/SubviewTag.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/SubviewTag.java)
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/validator/test.jsp
ADD /shale/framework/trunk/shale-view/src/test
MODIFY /shale/framework/trunk/shale-apps/shale-mailreader/pom.xml
ADD /shale/framework/trunk/shale-view/pom.xml

Repository Revision Date User Message
ASF #451490 Fri Sep 29 23:29:13 UTC 2006 craigmcc Add the new shale-view module as a module in shale-parent (so it will get
built with the others), and add it to the assembly output as well.

SHALE-299
Files Changed
MODIFY /shale/framework/trunk/pom.xml
MODIFY /shale/framework/trunk/shale-dist/src/assemble/dist.xml
MODIFY /shale/framework/trunk/shale-dist/pom.xml

Repository Revision Date User Message
ASF #451610 Sat Sep 30 16:56:02 UTC 2006 craigmcc Clean up APIs (plus some checkstyle warnings) after separating the shale-view
module out of the core library. Migrate a couple of constants from
FacesContstants (internal implementation) to Constants (available for
application use).

SHALE-299
Files Changed
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/ViewViewHandler.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/LifecycleListener.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/FacesConstants.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/ViewControllerCallbacks.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/package.html
MODIFY /shale/framework/trunk/shale-apps/shale-test-core/src/main/java/org/apache/shale/examples/test/core/Status.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/SubviewComponent.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/ViewPhaseListener.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/Constants.java
MODIFY /shale/framework/trunk/shale-apps/shale-test-tiger/src/main/java/org/apache/shale/examples/test/tiger/Status.java
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/ViewActionListener.java

Repository Revision Date User Message
ASF #451616 Sat Sep 30 17:10:01 UTC 2006 craigmcc Rename "shale-test-core" to "shale-test-view" since it tests the view
controller functionality that is now migrated out of the core library.

SHALE-299
Files Changed
REPLACE /shale/framework/trunk/shale-apps/shale-test-view/pom.xml (from /shale/framework/trunk/shale-apps/shale-test-core/pom.xml)
DEL /shale/framework/trunk/shale-apps/shale-test-view/src/main/java/org/apache/shale/examples/test/core/Standard.java
ADD /shale/framework/trunk/shale-apps/shale-test-view/src/main/java/org/apache/shale/examples/test/view/Status.java
DEL /shale/framework/trunk/shale-apps/shale-test-core
ADD /shale/framework/trunk/shale-apps/shale-test-view/src/main/java/org/apache/shale/examples/test/view
ADD /shale/framework/trunk/shale-apps/shale-test-view/src/main/java/org/apache/shale/examples/test/view/Standard.java
MODIFY /shale/framework/trunk/shale-apps/pom.xml
MODIFY /shale/framework/trunk/shale-apps/shale-test-view/src/main/webapp/WEB-INF/faces-config.xml
ADD /shale/framework/trunk/shale-apps/shale-test-view (from /shale/framework/trunk/shale-apps/shale-test-core)
DEL /shale/framework/trunk/shale-apps/shale-test-view/src/main/java/org/apache/shale/examples/test/core/Status.java
REPLACE /shale/framework/trunk/shale-apps/shale-test-view/src (from /shale/framework/trunk/shale-apps/shale-test-core/src)
MODIFY /shale/framework/trunk/shale-apps/shale-test-view/src/main/java/org/apache/shale/examples/test/core

Repository Revision Date User Message
ASF #451638 Sat Sep 30 19:10:34 UTC 2006 craigmcc Factor Commons Validator support out of shale-core into a new module
"shale-validator". We do not yet have any example or test applications
using this code, so we cannot yet verify correct operation. In addition,
the current implementation uses JSP tags with behavior in some cases,
which will cause integration difficulties with non-JSP view handler
implementations such as Clay and Facelets.

SHALE-299
Files Changed
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/component/ValidatorScript.java
ADD /shale/framework/trunk/shale-validator/src/test/resources/org/apache/shale
ADD /shale/framework/trunk/shale-validator/src/main/java
ADD /shale/framework/trunk/shale-validator/src/main/resources/org/apache/shale/validator/resources/Bundle.properties (from /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/resources/Bundle.properties)
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/renderer/ValidatorCommandRenderer.java
ADD /shale/framework/trunk/shale-validator/src/main/resources/META-INF
ADD /shale/framework/trunk/shale-validator/src/test/resources/org/apache/shale/validator (from /shale/framework/trunk/shale-core/src/test/resources/org/apache/shale/validator)
DEL /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/validator
ADD /shale/framework/trunk/shale-validator/src/main/resources/META-INF/NOTICE.txt (from /shale/framework/trunk/shale-core/src/main/resources/META-INF/NOTICE.txt)
ADD /shale/framework/trunk/shale-validator
MODIFY /shale/framework/trunk/shale-validator/src/test/java/org/apache/shale/validator/ValidatorDefaultTestCase.java
MODIFY /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/resources/Bundle.properties
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorScriptTag.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/ValidatorScriptTag.java)
ADD /shale/framework/trunk/shale-validator/src/test/java
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorCommandRenderer.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/renderer/ValidatorCommandRenderer.java)
DEL /shale/framework/trunk/shale-core/src/test/resources/org/apache/shale/validator
ADD /shale/framework/trunk/shale-validator/src/main/resources/META-INF/faces-config.xml (from /shale/framework/trunk/shale-core/src/main/resources/META-INF/faces-config.xml)
ADD /shale/framework/trunk/shale-validator/src/main
MODIFY /shale/framework/trunk/shale-view/src/main/java/org/apache/shale/view/faces/ViewViewHandler.java
ADD /shale/framework/trunk/shale-validator/src/test/resources/org
ADD /shale/framework/trunk/shale-validator/src/main/resources/org/apache/shale/validator/resources
ADD /shale/framework/trunk/shale-validator/src/main/resources/META-INF/taglib.tld (from /shale/framework/trunk/shale-core/src/main/resources/META-INF/taglib.tld)
ADD /shale/framework/trunk/shale-validator/src/test/java/org/apache/shale
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/ValidatorVarTag.java
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorVarTag.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/ValidatorVarTag.java)
MODIFY /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/CommonsValidator.java
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/validator
ADD /shale/framework/trunk/shale-validator/src/test/java/org/apache/shale/validator (from /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/validator)
ADD /shale/framework/trunk/shale-validator/src/main/resources/META-INF/LICENSE.txt (from /shale/framework/trunk/shale-core/src/main/resources/META-INF/LICENSE.txt)
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorRenderKit.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/faces/ValidatorRenderKit.java)
ADD /shale/framework/trunk/shale-validator/src/main/java/org
ADD /shale/framework/trunk/shale-validator/src
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorTag.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/CommonsValidatorTag.java)
ADD /shale/framework/trunk/shale-validator/src/test/java/org
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/renderer/ValidatorInputRenderer.java
ADD /shale/framework/trunk/shale-validator/src/main/resources
ADD /shale/framework/trunk/shale-validator/src/main/resources/org/apache
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces
MODIFY /shale/framework/trunk/shale-core/src/main/resources/META-INF/faces-config.xml
ADD /shale/framework/trunk/shale-validator/src/test
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/CommonsValidatorTag.java
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/taglib/ValidatorScriptTag.java
ADD /shale/framework/trunk/shale-validator/src/test/resources/org/apache
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorInputRenderer.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/renderer/ValidatorInputRenderer.java)
MODIFY /shale/framework/trunk/shale-validator/src/test/java/org/apache/shale/validator/CommonsValidatorTestCase.java
ADD /shale/framework/trunk/shale-validator/pom.xml
MODIFY /shale/framework/trunk/shale-core/src/main/resources/META-INF/taglib.tld
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/faces/ValidatorRenderKit.java
DEL /shale/framework/trunk/shale-core/src/test/java/org/apache/shale/validator
MODIFY /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/Globals.java
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorViewHandler.java
MODIFY /shale/framework/trunk/shale-core/pom.xml
ADD /shale/framework/trunk/shale-validator/src/main/resources/org
ADD /shale/framework/trunk/shale-validator/src/main/resources/org/apache/shale
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator/faces/ValidatorScript.java (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/component/ValidatorScript.java)
ADD /shale/framework/trunk/shale-validator/src/main/resources/org/apache/shale/validator (from /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/validator)
ADD /shale/framework/trunk/shale-validator/src/test/resources
ADD /shale/framework/trunk/shale-validator/src/main/java/org/apache/shale/validator (from /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/validator)
ADD /shale/framework/trunk/shale-validator/src/test/java/org/apache

Repository Revision Date User Message
ASF #451646 Sat Sep 30 19:32:11 UTC 2006 craigmcc Initial website content for shale-validator.

SHALE-299
Files Changed
ADD /shale/framework/trunk/shale-validator/src/site/xdoc
ADD /shale/framework/trunk/shale-validator/src/site/site.xml
ADD /shale/framework/trunk/shale-validator/src/site
ADD /shale/framework/trunk/shale-validator/src/site/xdoc/index.xml

Repository Revision Date User Message
ASF #451652 Sat Sep 30 19:56:36 UTC 2006 craigmcc Add shale-validator as a dependency, update to new tag library.

SHALE-299
Files Changed
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/validator/test.jsp
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/pom.xml
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/validator/thankYou.jsp

Repository Revision Date User Message
ASF #451667 Sat Sep 30 21:08:57 UTC 2006 craigmcc Incorporate shale-validator into the parent POM's dependencies, and the
distribution.

SHALE-299
Files Changed
MODIFY /shale/framework/trunk/pom.xml
MODIFY /shale/framework/trunk/shale-dist/src/assemble/dist.xml
MODIFY /shale/framework/trunk/shale-dist/pom.xml

Repository Revision Date User Message
ASF #451699 Sat Sep 30 23:47:31 UTC 2006 craigmcc Add an exclusion for xml-apis to the shale-validator POM, so that all
downstream users will receive it. Remove the explicit dependency on
Commons Validator in shale-usecases, because the correct dependencies
are now getting transitively inherited.

SHALE-299
Files Changed
MODIFY /shale/framework/trunk/shale-apps/shale-test-view/src/main/webapp/META-INF/context.xml
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/pom.xml
MODIFY /shale/framework/trunk/shale-validator/pom.xml

Repository Revision Date User Message
ASF #451717 Sun Oct 01 05:33:41 UTC 2006 craigmcc Remove the deprecated 'org.apache.shale.remote' package, and its
associated use cases tests.

SHALE-299
Files Changed
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/WEB-INF/chain-config.xml
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/remote
DEL /shale/framework/trunk/shale-apps/shale-usecases/src/main/java/org/apache/shale/usecases/remote
MODIFY /shale/framework/trunk/shale-apps/shale-usecases/src/main/webapp/usecases.jsp
MODIFY /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/faces/shale-config.xml
DEL /shale/framework/trunk/shale-apps/shale-usecases/src/test/java/org/apache/shale/usecases/remote

Repository Revision Date User Message
ASF #454219 Sun Oct 08 21:45:18 UTC 2006 wsmoak Remove duplicate 'features' pages and adjust the menu links to point to the new shale-validator and shale-view module index pages.

SHALE-299
Files Changed
DEL /shale/framework/trunk/src/site/xdoc/features-view-controller.xml
MODIFY /shale/framework/trunk/src/site/site.xml
DEL /shale/framework/trunk/src/site/xdoc/features-commons-validator.xml

Repository Revision Date User Message
ASF #463462 Thu Oct 12 22:14:32 UTC 2006 craigmcc Move a forgotten resource file from shale-core to shale-application. Also,
remove from it the intialization and cleanup of the original dialog
implementation, because that has now been farmed out to shale-dialog.

SHALE-299
Files Changed
ADD /shale/framework/trunk/shale-application/src/main/resources/org/apache/shale/application/faces
ADD /shale/framework/trunk/shale-application/src/main/resources/org/apache/shale/application/faces/shale-config.xml (from /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/faces/shale-config.xml)
ADD /shale/framework/trunk/shale-application/src/main/resources/org/apache
MODIFY /shale/framework/trunk/shale-application/src/main/java/org/apache/shale/application/faces/ShaleApplicationFilter.java
ADD /shale/framework/trunk/shale-application/src/main/resources/org/apache/shale
ADD /shale/framework/trunk/shale-application/src/main/resources/org/apache/shale/application
DEL /shale/framework/trunk/shale-core/src/main/resources/org/apache/shale/faces/shale-config.xml
ADD /shale/framework/trunk/shale-application/src/main/resources/org

Repository Revision Date User Message
ASF #467464 Tue Oct 24 20:21:50 UTC 2006 rahul Recommend different short names for new taglibs. Changing to val for shale-validator and v for shale-view.
SHALE-299
Files Changed
MODIFY /shale/framework/trunk/shale-validator/src/main/resources/META-INF/taglib.tld
MODIFY /shale/framework/trunk/shale-view/src/main/resources/META-INF/taglib.tld

Repository Revision Date User Message
ASF #467754 Wed Oct 25 20:41:24 UTC 2006 rahul Remove empty directory (the contents moved to the shale-application module)
SHALE-299
Files Changed
DEL /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/application


Powered by a free Atlassian JIRA open source license for Apache Software Foundation - Struts. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators