[#SHALE-296] lifecycleListener removes too many servletRequest attributes in case of requestDestroyed

Shale

lifecycleListener removes too many servletRequest attributes in case of requestDestroyed

Created: 28/Sep/06 06:06 PM Updated: 23/Jan/07 04:40 PM

Return to search

Component/s:

Core

Affects Version/s:

None

Fix Version/s:

1.0.4

File Attachments:

	File Name	Date Attached	Attached By	Size
	lifecycle_removed_attrs.diff	2006-09-28 06:07 PM	Mario Ivankovits	0.8 kB

Description

« Hide

one side effect is, that a error page which should be shown is no longer possible to view the exception as the lifecycleListener has removed it from the map.

From the comment a few lines above the code piece in queston I guessed what was the original intention.

All

Comments

Change History

Subversion Commits

Sort Order:

Mario Ivankovits made changes - 28/Sep/06 06:07 PM

Field	Original Value	New Value
Attachment		lifecycle_removed_attrs.diff [ 13160 ]

Repository	Revision	Date	User	Message
ASF	#451376	Fri Sep 29 18:20:32 UTC 2006	craigmcc	Reduce the set of request scoped beans that are forcibly removed in requestDestroyed(). In theory this should not be necessary, because the container is supposed to call requestDestroyed() only after all request processing has been completed. Alas, this is apparantly not true in all cases. Therefore, we should only delete instances for which we are going to create a destroy() callback for (AbstractRequestBean and ViewController). Based on a patch by Mario Ivankovits. ~~SHALE-296~~
				Files Changed
				MODIFY /shale/framework/trunk/shale-core/src/main/java/org/apache/shale/view/faces/LifecycleListener.java

[ Permlink | « Hide ]

Craig McClanahan added a comment - 29/Sep/06 06:21 PM

Fixed in nightly build 20060930. I modified your patch slightly to include instances of ViewController (as well as AbstractRequestBean) because we want to trigger destroy() callbacks on both of these.

Craig McClanahan made changes - 29/Sep/06 06:21 PM

Fix Version/s		1.0.4-SNAPSHOT [ 21740 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Rahul Akolkar made changes - 23/Jan/07 04:40 PM

Fix Version/s	1.0.4-SNAPSHOT [ 21740 ]
Fix Version/s		1.0.4 [ 21790 ]

Jeff Turner made changes - 09/Aug/07 07:15 AM

Workflow

Struts [ 38772 ]

Struts - editable closed status [ 41707 ]

Antonio Petrelli made changes - 08/Jan/09 08:56 AM

Workflow

Struts - editable closed status [ 41707 ]

Struts - editable closed status (temporary) [ 46035 ]

Antonio Petrelli made changes - 08/Jan/09 09:08 AM

Workflow

Struts - editable closed status (temporary) [ 46035 ]

Struts - editable closed status [ 52716 ]