Build failures post r443256 refactoring

• Key: SHALE-289
• Type: Bug
• Status: Resolved
• Resolution: Cannot Reproduce
• Priority: Major
• Assignee: Craig McClanahan
• Reporter: Rahul Akolkar
• Affects Version/s: 1.0.4-SNAPSHOT

Description

Post r443256 [1], the framework build is failing for vanilla m204 users. Details are in this [2] discussion thread.

[1] http://svn.apache.org/viewvc?view=rev&revision=443256
[2] http://www.nabble.com/Building-from-subversion-source-tf2296108.html

Comments

[Wendy Smoak]

My proposed workaround is to explicitly declare a dependency on commons-validator with a version number in shale-core.

To make sure this gets fixed, we should construct a simple two-level project with just commons-validator and myfaces as dependencies, and attach it to a Maven JIRA issue.

[Rahul Akolkar]

I'm traveling, and haven't had time for much, but the only thing that seems to convince my ThinkPad to build is to uncomment the profiles in shale-parent (so the default myfaces profile gets used). Your suggestion didn't cut it for me, I cannot say why. Oh well, I'll do what I have to, to build for now ...

[Craig McClanahan]

Rahul,

In your stack trace, the compile error occurs in org.apache.shale.component.ValidatorScript in the shale *core* module. However, this is one of the many classes that got moved into the shale-validator module instead. This implies that perhaps your source tree does not completely reflect the updates? (One thing that can cause this is if you had changes in one of the files that was moved, Subversion would not have actually moved that particular file.

Could you try checking out the source tree again, and then trying this? For me, there is no ValidatorScript file in shale-core, so I cannot reproduce the issue.

Craig

[Rahul Akolkar]

Its a shame you spent any time looking at this, the only reason this was open is because I couldn't close it ( SHALE-293 fixed it for me, see my last comment there asking for help to close this one ).

While we're at it, do consider SHALE-263 and SHALE-268 to be "assigned" to me (since I can't do that myself). I think solutions to both are in reasonable shape in the sandbox.

Maybe I should post such notes on the list for better visibility ...

(Am counting on JIRA to link the above mentioned issues in).

[Craig McClanahan]

   [[ Old comment, sent by email on Wed, 11 Oct 2006 16:01:48 -0700 ]]

On 10/11/06, Rahul Akolkar (JIRA) <[e-mail]> wrote:
 >
 > [
 > http://issues.apache.org/struts/browse/SHALE-289?page=comments#action_38372]
 >
 > Rahul Akolkar commented on SHALE-289:
 > -------------------------------------
 >
 > Its a shame you spent any time looking at this, the only reason this was
 > open is because I couldn't close it ( SHALE-293 fixed it for me, see my last
 > comment there asking for help to close this one ).


Good.

It didn't really cost me more than the time to scan the stack trace to see
classes that should be there any more :-).

While we're at it, do consider SHALE-263 and SHALE-268 to be "assigned" to
 > me (since I can't do that myself). I think solutions to both are in
 > reasonable shape in the sandbox.


I should be able to assign them to you myself ... let me try.

Maybe I should post such notes on the list for better visibility ...


Posting it on the issue itself (as a comment) would be best ... that way
it's right there when someone is reviewing the issue as a whole.

Craig

(Am counting on JIRA to link the above mentioned issues in).